-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Fix links to Logs view to point to Discover in Serverless #171525
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
@elasticmachine merge upstream |
Pinging @elastic/fleet (Team:Fleet) |
...s/fleet/public/applications/fleet/sections/agents/agent_list_page/components/view_errors.tsx
Outdated
Show resolved
Hide resolved
...ications/fleet/sections/agents/agent_details_page/components/agent_logs/view_logs_button.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small suggestions but otherwise LGTM 🚀
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @criamico |
Fixes #168349
Summary
Fix links to Logs view to point to Discover in Serverless.
As the Logs view UI is not available in serverless, the "Open in logs" buttons should point to Discover instead. Rather than hardcode the url in each of the places where is needed, I extracted a small component that builds the two urls and allows switching in an easier way.
If in the future on of the two links will go away, it will be easier to find those occurrences.
Testing
Test for serverless following these instructions
Error logs in agent activity flyout
Agent logs
(Same test as above)
Custom Logs UI
There is also a link to logs on custom logs UI but I just linked to discover for that one: https://github.com/elastic/kibana/pull/171525/files#diff-e337aa916d60d0d1033e3298c8c9c33c6a6fcd87a8ded971a4a87f5ccfc0981fR20-R22