Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Serverless] Increase root breadcrumb width to reduce elipsis #171515

Merged
merged 1 commit into from
Nov 21, 2023
Merged

[Serverless] Increase root breadcrumb width to reduce elipsis #171515

merged 1 commit into from
Nov 21, 2023

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Nov 20, 2023 •
edited
Loading

Summary

close #170758

This PR increases root breadcrumb max width from 160 to 320px to fit more of project titles. It also slightly adjusts number of visible breadcrumbs per breakpoint to account for potentially 2x longer root breadcrumb. Note that responsiveness is still not ideal as the system doesn't actually calculate the width of each breadcrumb.

Before:

Screenshot 2023-11-20 at 11 53 13

After:

Screenshot 2023-11-20 at 11 52 31

@Dosant Dosant changed the title increase root breadcrumb width, improve breadcrumbs responsiveness [Serverless] Increase root breadcrumb width to reduce elipsis Nov 20, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 374.0KB 374.1KB +53.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Project:Serverless Work as part of the Serverless project for its initial release Feature:Chrome Core's Chrome UI (sidenav, header, breadcrumbs) release_note:skip Skip the PR/issue when compiling release notes labels Nov 20, 2023
@Dosant Dosant marked this pull request as ready for review November 20, 2023 13:30
@Dosant Dosant requested a review from a team as a code owner November 20, 2023 13:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@Dosant Dosant mentioned this pull request Nov 20, 2023
Closed
eokoneyo
eokoneyo approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@eokoneyo eokoneyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested code changes, LGTM.

@Dosant Dosant merged commit f4e0d83 into elastic:main Nov 21, 2023
9 checks passed
@Dosant Dosant self-assigned this Nov 21, 2023
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eokoneyo eokoneyo eokoneyo approved these changes

Assignees

@Dosant Dosant

Labels
backport:skip This commit does not require backporting Feature:Chrome Core's Chrome UI (sidenav, header, breadcrumbs) Project:Serverless Work as part of the Serverless project for its initial release release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Serverless] Project names should be extended to reduce elipsis
5 participants
@Dosant @kibana-ci @elasticmachine @eokoneyo @kibanamachine