Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moves SOR bulkCreate unit tests to dedicated file #171431

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Moves SOR bulkCreate unit tests to dedicated file #171431

merged 1 commit into from
Nov 21, 2023
+1,048 −916

Conversation

TinaHeiligers
Copy link
Contributor

@TinaHeiligers TinaHeiligers commented Nov 16, 2023 •
edited
Loading

Moves saved objects repository bulkCreate api unit tests to their own dedicated file alongside the API implementation code.

Addresses: tech debt (& devEx w.r.t SOR work)

Needed for: inspiration for BWC bulkUpdate unit test refactoring

@TinaHeiligers TinaHeiligers added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Saved Objects technical debt Improvement of the software architecture and operational architecture release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Epic:ZDTmigrations Zero downtime migrations labels Nov 16, 2023
@TinaHeiligers TinaHeiligers requested a review from a team as a code owner November 16, 2023 17:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.8MB 12.8MB +6.4KB
securitySolutionServerless 330.6KB 336.9KB +6.3KB
total +12.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolutionServerless 41.7KB 41.7KB -1.0B
Unknown metric groups

ESLint disabled in files

id before after diff
@kbn/core-saved-objects-api-server-internal 3 4 +1

Total ESLint disabled count

id before after diff
@kbn/core-saved-objects-api-server-internal 9 10 +1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jloleysens
jloleysens approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@TinaHeiligers TinaHeiligers merged commit d8ef2d0 into elastic:main Nov 21, 2023
13 checks passed
@TinaHeiligers TinaHeiligers self-assigned this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

Assignees

@TinaHeiligers TinaHeiligers

Labels
backport:skip This commit does not require backporting Epic:ZDTmigrations Zero downtime migrations Feature:Saved Objects release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TinaHeiligers @elasticmachine @kibana-ci @jloleysens @kibanamachine