Redesign Share context menu

packages/kbn-optimizer/limits.yml

@@ -113,7 +113,7 @@ pageLoadAssetSize:
   presentationUtil: 58834
   profiling: 36694
   remoteClusters: 51327
-  reporting: 57003
+  reporting: 80238
   rollup: 97204
   runtimeFields: 41752
   savedObjects: 108518

packages/kbn-reporting/export_types/csv_common/index.ts

@@ -53,3 +53,7 @@ export const CSV_REPORT_TYPE_DEPRECATED = 'CSV';
 export const CSV_JOB_TYPE_DEPRECATED = 'csv';
 
 export { getQueryFromCsvJob, type QueryInspection } from './lib/get_query_from_job';
+
+export type JobAppParamsCSV = (
+  forShareUrl?: boolean | undefined
+) => Omit<BaseParams, 'browserTimezone' | 'version'>;

src/plugins/dashboard/public/dashboard_app/top_nav/share/show_share_modal.test.tsx

@@ -12,6 +12,7 @@ import { convertPanelMapToSavedPanels, DashboardContainerInput } from '../../../
 
 import { pluginServices } from '../../../services/plugin_services';
 import { showPublicUrlSwitch, ShowShareModal, ShowShareModalProps } from './show_share_modal';
+import { overlayServiceMock } from '@kbn/core-overlays-browser-mocks';
 
 describe('showPublicUrlSwitch', () => {
   test('returns false if "dashboard" app is not available', () => {
@@ -74,6 +75,7 @@ describe('ShowShareModal', () => {
     return {
       isDirty: true,
       anchorElement: document.createElement('div'),
+      overlays: overlayServiceMock.createStartContract(),
     };
   };
 

src/plugins/dashboard/public/dashboard_app/top_nav/share/show_share_modal.tsx

@@ -13,7 +13,7 @@ import { omit } from 'lodash';
 import { i18n } from '@kbn/i18n';
 import { EuiCheckboxGroup } from '@elastic/eui';
 import { QueryState } from '@kbn/data-plugin/common';
-import type { Capabilities } from '@kbn/core/public';
+import type { Capabilities, HttpStart, OverlayStart } from '@kbn/core/public';
 import { ViewMode } from '@kbn/embeddable-plugin/public';
 import { getStateFromKbnUrl } from '@kbn/kibana-utils-plugin/public';
 import { setStateToKbnUrl, unhashUrl } from '@kbn/kibana-utils-plugin/public';
@@ -33,6 +33,8 @@ export interface ShowShareModalProps {
   savedObjectId?: string;
   dashboardTitle?: string;
   anchorElement: HTMLElement;
+  overlays: OverlayStart;
+  http?: HttpStart;
 }
 
 export const showPublicUrlSwitch = (anonymousUserCapabilities: Capabilities) => {
@@ -48,6 +50,8 @@ export function ShowShareModal({
   anchorElement,
   savedObjectId,
   dashboardTitle,
+  overlays,
+  http,
 }: ShowShareModalProps) {
   const {
     dashboardCapabilities: { createShortUrl: allowShortUrl },
@@ -197,5 +201,6 @@ export function ShowShareModal({
     snapshotShareWarning: Boolean(unsavedDashboardState?.panels)
       ? shareModalStrings.getSnapshotShareWarning()
       : undefined,
+    overlays,
   });
 }

src/plugins/dashboard/public/dashboard_app/top_nav/use_dashboard_menu_items.tsx

@@ -12,6 +12,7 @@ import { Dispatch, SetStateAction, useCallback, useMemo, useState } from 'react'
 import { ViewMode } from '@kbn/embeddable-plugin/public';
 import { TopNavMenuData } from '@kbn/navigation-plugin/public';
 
+import { HttpStart } from '@kbn/core/public';
 import { UI_SETTINGS } from '../../../common';
 import { useDashboardAPI } from '../dashboard_app';
 import { topNavStrings } from '../_dashboard_app_strings';
@@ -43,6 +44,8 @@ export const useDashboardMenuItems = ({
     dashboardBackup,
     settings: { uiSettings },
     dashboardCapabilities: { showWriteControls },
+    overlays,
+    http,
   } = pluginServices.getServices();
   const isLabsEnabled = uiSettings.get(UI_SETTINGS.ENABLE_LABS_UI);
 
@@ -72,9 +75,11 @@ export const useDashboardMenuItems = ({
         anchorElement,
         savedObjectId: lastSavedId,
         isDirty: Boolean(hasUnsavedChanges),
+        overlays,
+        http: http as HttpStart,
       });
     },
-    [dashboardTitle, hasUnsavedChanges, lastSavedId]
+    [dashboardTitle, hasUnsavedChanges, lastSavedId, http, overlays]
   );
 
   const maybeRedirect = useCallback(

src/plugins/discover/public/application/main/components/top_nav/get_top_nav_links.tsx

@@ -129,7 +129,7 @@ export const getTopNavLinks = ({
         isTextBased
       );
 
-      const { locator } = services;
+      const { locator, core } = services;
       const appState = state.appState.getState();
       const { timefilter } = services.data.query.timefilter;
       const timeRange = timefilter.getTime();
@@ -196,6 +196,8 @@ export const getTopNavLinks = ({
         onClose: () => {
           anchorElement?.focus();
         },
+        overlays: core.overlays,
+        http: core.http,
       });
     },
   };