Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ftr] split x-pack accessibility config in 3 groups #171186

Merged
merged 17 commits into from
Nov 28, 2023
Merged

[ftr] split x-pack accessibility config in 3 groups #171186

merged 17 commits into from
Nov 28, 2023

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Nov 14, 2023 •
edited by kibanamachine
Loading

Summary

Splitting long running FTR config:

image

After split:

Config Path Runtime
x-pack/test/accessibility/apps/group1/config.ts 10m 15s
x-pack/test/accessibility/apps/group2/config.ts 14m 31s
x-pack/test/accessibility/apps/group3/config.ts 11m 30s

@dmlemeshko dmlemeshko marked this pull request as ready for review November 15, 2023 13:48
@dmlemeshko dmlemeshko requested review from a team as code owners November 15, 2023 13:48
@dmlemeshko dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes FTR v8.12.0 v8.11.2 v8.11.1 v8.10.5 and removed v8.11.2 labels Nov 15, 2023
kc13greiner
kc13greiner approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pheyos
pheyos reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a few additional changes are required, e.g. in CODEOWNERS and some docs, see e.g. this list of search results: https://github.com/search?q=repo%3Aelastic%2Fkibana+content%3Ax-pack%2Ftest%2Faccessibility&type=code

davismcphee
davismcphee reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Discovery change looks good (moving /x-pack/test/accessibility/apps/search_sessions.ts), and should be good to go on our end once CODEOWNERS is updated.

@dmlemeshko
Copy link
Member Author

@elasticmachine merge upstream

@dmlemeshko dmlemeshko requested a review from a team November 20, 2023 17:36
pheyos
pheyos approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmlemeshko dmlemeshko enabled auto-merge (squash) November 20, 2023 18:10
davismcphee
davismcphee approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Discovery changes LGTM 👍

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Cypress Tests #2 / Correlation tab should update timeline after removing eql should update timeline after removing eql

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dmlemeshko dmlemeshko merged commit 0c49603 into elastic:main Nov 28, 2023
28 checks passed
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.11 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 171186

Questions ?

Please refer to the Backport tool documentation

@dmlemeshko dmlemeshko mentioned this pull request Nov 28, 2023
Closed
@dmlemeshko
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
✅ 8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Nov 28, 2023
@dmlemeshko
[ftr] split x-pack accessibility config in 3 groups (elastic#171186)
b9cdc44 
## Summary

Splitting long running FTR config:

<img width="1573" alt="image"
src="https://github.com/elastic/kibana/assets/10977896/160b97b4-6468-4c2f-9827-17f6bb9a742a">

After split:

| Config Path | Runtime |
| ------------- | ------------- |
| x-pack/test/accessibility/apps/group1/config.ts |  10m 15s  |
| x-pack/test/accessibility/apps/group2/config.ts | 14m 31s |
| x-pack/test/accessibility/apps/group3/config.ts | 11m 30s  |

---------

Co-authored-by: Kibana Machine <[email protected]>
(cherry picked from commit 0c49603)

# Conflicts:
#	.github/CODEOWNERS
#	x-pack/test/accessibility/config.ts
@dmlemeshko dmlemeshko added backport:skip This commit does not require backporting and removed v8.11.1 labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davismcphee davismcphee davismcphee approved these changes

@kc13greiner kc13greiner kc13greiner approved these changes

@jbudz jbudz jbudz approved these changes

@TattdCodeMonkey TattdCodeMonkey TattdCodeMonkey approved these changes

@pheyos pheyos pheyos approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting FTR release_note:skip Skip the PR/issue when compiling release notes v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dmlemeshko @kibana-ci @kibanamachine @pheyos @TattdCodeMonkey @jbudz @kc13greiner @davismcphee