[Cases] Opt in for file hashing. #171162
Merged
[Cases] Opt in for file hashing. #171162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcoelho
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/response-ops-cases (Feature:Cases) |
cnasikas
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
LGTM! Let's ask the InfoSec team (@daniel-gallagher @kayapuskarov @philrose66) if the hash algorithms make sense for them.
|
Added sha1 too after discussing the PR with @daniel-gallagher |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @adcoelho |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171071
Summary
In this PR we opt in for
md5,sha1, andsha256hashes that will be computed and stored automatically on.upload()calls to the files API.At the moment we don't do anything else with the hashes but we can confirm they are being generate in the Files Tab in the Cases Detail View. The Files Client list API now returns hashes.
See here.