Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Add a script to create roles and users #171067

Merged
merged 2 commits into from
Nov 13, 2023
Merged

[Security Solution] Add a script to create roles and users #171067

merged 2 commits into from
Nov 13, 2023

Conversation

maximpn
Copy link
Contributor

@maximpn maximpn commented Nov 11, 2023

Relates to: #169017

Summary

This PR re-adds an utility shell script for roles and users creation to replace scripts removed in a previous PR.

@maximpn maximpn added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team v8.11.0 v8.12.0 labels Nov 11, 2023
@maximpn maximpn self-assigned this Nov 11, 2023
@maximpn maximpn requested a review from yctercero November 11, 2023 10:04
@maximpn maximpn marked this pull request as ready for review November 11, 2023 10:04
@maximpn maximpn requested a review from a team as a code owner November 11, 2023 10:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@maximpn maximpn removed the v8.11.0 label Nov 11, 2023
@maximpn
Copy link
Contributor Author

maximpn commented Nov 12, 2023

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maximpn

yctercero
yctercero approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks so much for following up. Tagging @dhurley14 who was part of the discussions about keeping these scripts.

In chatting with Devin about my PR adding cypress tests around roles, it seems that there are some things we have to specify for ESS, that we don't for serverless in order to make the roles work in ESS. No action to take here, but just a note that we may need to differentiate between creating roles for each.

@maximpn maximpn merged commit 881a4bb into elastic:main Nov 13, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 13, 2023
@maximpn maximpn deleted the add-role-user-creation-script branch November 13, 2023 09:28
@logeekal logeekal mentioned this pull request Nov 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yctercero yctercero yctercero approved these changes

Assignees

@maximpn maximpn

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maximpn @elasticmachine @kibana-ci @yctercero @kibanamachine