-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Trained models list: disables 'View training data' action if data frame analytics job no longer exists #171061
Merged
alvarezmelissa87
merged 8 commits into
elastic:main
from
alvarezmelissa87:ml-dfa-view-training
Nov 21, 2023
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a407ee2
disable View Training Data if original job no longer exists
alvarezmelissa87 7c06abd
check all jobs exist at once. check permissions
alvarezmelissa87 6d8a4e5
create ViewTrainingData to wrap disabled action in tooltip
alvarezmelissa87 12f1a01
Merge branch 'main' into ml-dfa-view-training
kibanamachine 50ffcfd
refactor origin_job_exists check
alvarezmelissa87 8c7094d
update types and fix action in column
alvarezmelissa87 3bc2c8d
Merge branch 'main' into ml-dfa-view-training
kibanamachine 73216d0
ensure job id string is corrrect
alvarezmelissa87 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -130,18 +130,19 @@ export function useModelActions({ | |
return useMemo( | ||
() => [ | ||
{ | ||
name: i18n.translate('xpack.ml.trainedModels.modelsList.viewTrainingDataActionLabel', { | ||
name: i18n.translate('xpack.ml.trainedModels.modelsList.viewTrainingDataNameActionLabel', { | ||
defaultMessage: 'View training data', | ||
}), | ||
description: i18n.translate( | ||
'xpack.ml.trainedModels.modelsList.viewTrainingDataActionLabel', | ||
{ | ||
defaultMessage: 'View training data', | ||
defaultMessage: 'Training data can be viewed when data frame analytics job exists.', | ||
} | ||
), | ||
icon: 'visTable', | ||
type: 'icon', | ||
available: (item) => !!item.metadata?.analytics_config?.id, | ||
enabled: (item) => item.origin_job_exists === true, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a tooltip to show why the action is disabled. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added in 6d8a4e5 |
||
onClick: async (item) => { | ||
if (item.metadata?.analytics_config === undefined) return; | ||
|
||
|
@@ -164,7 +165,6 @@ export function useModelActions({ | |
|
||
await navigateToUrl(url); | ||
}, | ||
isPrimary: true, | ||
}, | ||
{ | ||
name: i18n.translate('xpack.ml.inference.modelsList.analyticsMapActionLabel', { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this needs to be optional route param. We should always perform this check when retrieving the models as it's useful information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in 7c06abd