Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Unskips and fixes detection_response tests #170937

Merged
merged 5 commits into from
Nov 10, 2023
Merged

[Security Solution] Unskips and fixes detection_response tests #170937

merged 5 commits into from
Nov 10, 2023

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Nov 9, 2023 •
edited
Loading

Summary

Fixes: #168772
Fixes: #168771

In this PR we are fixing and unskipipng all the tests inside the detection_response.cy.ts spec file.

The changes have been tested on the flaky test runner with 100 executions for ESS and 100 executions for serverless.

@MadameSheema MadameSheema force-pushed the unskips-detection-response branch from 71cca89 to 7bd1e1c Compare November 10, 2023 10:23
@MadameSheema MadameSheema changed the title unskips test [Security Solution] Unskips and fixes detection_response tests Nov 10, 2023
@MadameSheema MadameSheema self-assigned this Nov 10, 2023
@MadameSheema MadameSheema added v8.12.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team release_note:skip Skip the PR/issue when compiling release notes labels Nov 10, 2023
@MadameSheema MadameSheema marked this pull request as ready for review November 10, 2023 10:30
@MadameSheema MadameSheema requested a review from a team as a code owner November 10, 2023 10:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

janmonschke
janmonschke approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@janmonschke janmonschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@MadameSheema MadameSheema enabled auto-merge (squash) November 10, 2023 10:46
@MadameSheema MadameSheema merged commit 0ddbfc0 into elastic:main Nov 10, 2023
8 checks passed
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💛 Build #174659 was flaky 05127467240b62120331bb3150c5ba29677fdf19
  • 💔 Build #174579 failed 804ead878cdf60ec504601023f8be7d8553554e0

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @MadameSheema

@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 10, 2023
@MadameSheema MadameSheema deleted the unskips-detection-response branch November 10, 2023 11:34
@logeekal logeekal mentioned this pull request Nov 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janmonschke janmonschke janmonschke approved these changes

Assignees

@MadameSheema MadameSheema

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team v8.12.0
Projects
None yet
Milestone
No milestone
5 participants
@MadameSheema @elasticmachine @kibana-ci @janmonschke @kibanamachine