Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.11] [Security Solutions] Update risk score tables to filter by timerange (#168826) #170928

Merged
merged 5 commits into from
Nov 9, 2023

Conversation

machadoum
Copy link
Member

@machadoum machadoum commented Nov 9, 2023

Backport

This will backport the following commits from main to 8.11:

Now that the 8.11.0 release is closed https://github.com/elastic/dev/issues/2367 we can merge #168826 to 8.11.1

Questions ?

Please refer to the Backport tool documentation

\r\n\r\n### Questions ?\r\nPlease refer to the [Backport tool\r\ndocumentation](https://github.com/sqren/backport)\r\n\r\n"}}]}] BACKPORT-->

…lastic#168826)

issue: elastic#162451

## Summary

* Update Entity analytics dashboard to filter by timerange and to
display timestamp field
* Update Users risk score tab to filter by timerange and to display
timestamp field
* Update Hosts risk score tab to filter by timerange and to display
timestamp field
* Delete tooltip that used to warn users that risk tables din't filter
by timerange

<img width="1501" alt="Screenshot 2023-10-13 at 11 54 19"
src="https://github.com/elastic/kibana/assets/1490444/a99e6ec7-0cbd-44a9-b1b1-b2dc9f4ad7cf">
<img width="1506" alt="Screenshot 2023-10-13 at 11 54 38"
src="https://github.com/elastic/kibana/assets/1490444/78f59c54-9210-4d09-8e22-bdab1b2103c5">
<img width="1497" alt="Screenshot 2023-10-13 at 11 54 53"
src="https://github.com/elastic/kibana/assets/1490444/35c19ee4-3cbc-42f5-96c1-1c63dc47300b">

### How to test
* Create alerts and enable the risk engine
* Check if the Entity analytics dashboard filters by timerange
* Check if the Users risk score tab filters by timerange
* Check if the Hosts risk score tab filters by timerange
* Check if the risk score on top of the user details page does NOT
filter by timerange
* Check if the risk score inside flyouts (Alerts, users and hosts) does
NOT filter by timerange
* Check if the info tooltips about the timerange filter were removed

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit e12cfc1)

# Conflicts:
#	x-pack/plugins/security_solution/public/explore/containers/risk_score/kpi/index.tsx
#	x-pack/plugins/translations/translations/fr-FR.json
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
#	x-pack/test/security_solution_cypress/cypress/e2e/explore/dashboards/entity_analytics.cy.ts
@machadoum machadoum force-pushed the backport/8.11/pr-168826 branch from bca0b1f to 01187d3 Compare November 9, 2023 13:58
@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 9, 2023

💔 Build Failed

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.0MB 13.0MB -1.2KB
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 456 454 -2

Total ESLint disabled count

id before after diff
securitySolution 523 521 -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @machadoum

@machadoum machadoum merged commit a1b0773 into elastic:8.11 Nov 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants