-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.11] [Security Solutions] Update risk score tables to filter by timerange (#168826) #170928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lastic#168826) issue: elastic#162451 ## Summary * Update Entity analytics dashboard to filter by timerange and to display timestamp field * Update Users risk score tab to filter by timerange and to display timestamp field * Update Hosts risk score tab to filter by timerange and to display timestamp field * Delete tooltip that used to warn users that risk tables din't filter by timerange <img width="1501" alt="Screenshot 2023-10-13 at 11 54 19" src="https://github.com/elastic/kibana/assets/1490444/a99e6ec7-0cbd-44a9-b1b1-b2dc9f4ad7cf"> <img width="1506" alt="Screenshot 2023-10-13 at 11 54 38" src="https://github.com/elastic/kibana/assets/1490444/78f59c54-9210-4d09-8e22-bdab1b2103c5"> <img width="1497" alt="Screenshot 2023-10-13 at 11 54 53" src="https://github.com/elastic/kibana/assets/1490444/35c19ee4-3cbc-42f5-96c1-1c63dc47300b"> ### How to test * Create alerts and enable the risk engine * Check if the Entity analytics dashboard filters by timerange * Check if the Users risk score tab filters by timerange * Check if the Hosts risk score tab filters by timerange * Check if the risk score on top of the user details page does NOT filter by timerange * Check if the risk score inside flyouts (Alerts, users and hosts) does NOT filter by timerange * Check if the info tooltips about the timerange filter were removed ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit e12cfc1) # Conflicts: # x-pack/plugins/security_solution/public/explore/containers/risk_score/kpi/index.tsx # x-pack/plugins/translations/translations/fr-FR.json # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json # x-pack/test/security_solution_cypress/cypress/e2e/explore/dashboards/entity_analytics.cy.ts
2 tasks
nkhristinin
approved these changes
Nov 9, 2023
machadoum
force-pushed
the
backport/8.11/pr-168826
branch
from
November 9, 2023 13:58
bca0b1f
to
01187d3
Compare
💔 Build FailedFailed CI Steps
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @machadoum |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
main
to8.11
:Now that the 8.11.0 release is closed https://github.com/elastic/dev/issues/2367 we can merge #168826 to 8.11.1
Questions ?
Please refer to the Backport tool documentation
\r\n\r\n### Questions ?\r\nPlease refer to the [Backport tool\r\ndocumentation](https://github.com/sqren/backport)\r\n\r\n"}}]}] BACKPORT-->