-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] [Unified Search] Fix field truncation on Combo boxes #170889
Conversation
338bd7f
to
ee9be1b
Compare
ee9be1b
to
d3a7379
Compare
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
53f969c
to
23fe8af
Compare
23fe8af
to
f9a2e6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a general improvement with this PR with all fields with long names.
Found some bugs, but unsure whether they are strictly related with the scope of this PR or need to be fixed in a next iteration (either way I'm fine):
- If the selected field name is very long it can overflow the filter popover
(On Edge browser)
- it seems values are now showing up in the filter values section:
But I see values when aggregating:
|
||
return ( | ||
<div ref={comboBoxRef}> | ||
<div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need this div
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right, nope!
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
History
To update your PR or re-run it, just comment with: |
Summary
Fixes 3/5 of #168753
Doesn't set up multilines. Doesn't remove auto-expanding logic. Middle truncates.
(Unified Search) Field selector
(Unified Search) Value selector:
(Lens) Field picker within layer config:
Also fixes tiny stylistic issue for dataview picker label cut on the bottom: