[8.11] [Controls] Fix flaky a11y test (#169559)
#170771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes elastic#169542 ## Summary For some reason, the search session popover was being opened, which blocked the controls button from being clickable:  I'm unsure why this popover is open to begin with; this should **only** happen when the `searchSessionIndicator` button is clicked, but this button is **not** interacted with in **any** of the accessibility tests (that I could find). This makes me suspicious that this is actually a **misclick** - i.e. the element that was meant to be clicked gets moved (possibly the Dashboard "edit" button?), which causes the `searchSessionIndicator` button to be clicked instead. Going off this theory, I've switched the controls `a11y` tests to use the Dashboard page's methods (which have more safeguards in place) to navigate to the desired dashboard rather than clicking elements solely based off of the `data-test-subj` like we were previously. ### [Flaky Test Runner](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3686)  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit ad932ec)
2 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @Heenawter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.11:a11ytest (#169559)Questions ?
Please refer to the Backport tool documentation