Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Revert security_solution_cypress package.json change #170663

Merged
merged 7 commits into from
Nov 8, 2023
Merged

[Security Solution] Revert security_solution_cypress package.json change #170663

merged 7 commits into from
Nov 8, 2023

Conversation

jpdjere
Copy link
Contributor

@jpdjere jpdjere commented Nov 6, 2023

Summary

@jpdjere jpdjere self-assigned this Nov 6, 2023
@jpdjere jpdjere added Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Nov 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@jpdjere jpdjere added the release_note:skip Skip the PR/issue when compiling release notes label Nov 6, 2023
@jpdjere jpdjere requested a review from a team November 6, 2023 16:41
@jpdjere jpdjere enabled auto-merge (squash) November 6, 2023 16:53
@jpdjere
Copy link
Contributor Author

jpdjere commented Nov 6, 2023

@elasticmachine merge upstream

@kibanamachine kibanamachine requested a review from a team as a code owner November 6, 2023 20:09
MadameSheema
MadameSheema approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@MadameSheema MadameSheema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-engineering-productivity LGTM

auto-merge was automatically disabled November 7, 2023 05:06

Merge queue setting changed

@jpdjere jpdjere requested a review from a team as a code owner November 7, 2023 08:13
@jpdjere jpdjere requested a review from dplumlee November 7, 2023 08:13
@jpdjere
Copy link
Contributor Author

jpdjere commented Nov 7, 2023

Skipped Cypress test for Serverless:

x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/rule_actions/bulk_actions/bulk_edit_rules_actions.cy·ts

Detection rules, bulk edit of rule actions Restricted action privileges User with no privileges can't add rule actions User with no privileges can't add rule actions

@jpdjere
Copy link
Contributor Author

jpdjere commented Nov 7, 2023

@elasticmachine merge upstream

@banderror
Copy link
Contributor

@jpdjere Is the test you mention in #170663 (comment) broken in 8.11 as well? Should we backport this PR to 8.11?

@banderror banderror added bug Fixes for quality problems that affect the customer experience Team:Detection Rule Management Security Detection Rule Management Team labels Nov 7, 2023
@jpdjere
Copy link
Contributor Author

jpdjere commented Nov 7, 2023

@jpdjere Is the test you mention in #170663 (comment) broken in 8.11 as well? Should we backport this PR to 8.11?

@banderror The failures for this test appeared only in this PR, haven't seen it happen for any PR pointing for 8.11 yet, even though I have a couple of backports to 8.11 open. I'm going to investigate further.

auto-merge was automatically disabled November 7, 2023 12:31

Merge queue setting changed

@jpdjere jpdjere mentioned this pull request Nov 7, 2023
Open
@jpdjere
Copy link
Contributor Author

jpdjere commented Nov 7, 2023

Waiting to merge #170540, which skips the failing tests for this PR

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Cypress Tests #3 / Timeline search and filters Update kqlMode for timeline "before each" hook for "should be able to update timeline kqlMode with filter" "before each" hook for "should be able to update timeline kqlMode with filter"

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jpdjere

@jpdjere jpdjere merged commit 7449cdb into elastic:main Nov 8, 2023
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Nov 8, 2023
@banderror
Copy link
Contributor

@jpdjere Could you please open a ticket for unskipping the tests skipped in this PR #170663 (comment) ?

@jpdjere jpdjere mentioned this pull request Nov 13, 2023
Closed
@jpdjere
Copy link
Contributor Author

jpdjere commented Nov 13, 2023

@jpdjere Could you please open a ticket for unskipping the tests skipped in this PR #170663 (comment) ?

Here's the issue: #171101

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadameSheema MadameSheema MadameSheema approved these changes

@banderror banderror banderror approved these changes

@dplumlee dplumlee Awaiting requested review from dplumlee dplumlee is a code owner automatically assigned from elastic/security-detection-rule-management

Assignees

@jpdjere jpdjere

Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jpdjere @elasticmachine @banderror @kibana-ci @MadameSheema @kibanamachine