Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs Explorer] Flyout details ai assistant registration #170658

Conversation

tonyghiani
Copy link
Contributor

@tonyghiani tonyghiani commented Nov 6, 2023

📓 Summary

Closes #169506

This PR introduces a mechanism to apply customizations on the LogExplorer component.
The first necessary customization which is implemented is for the flyout detail, allowing the consumer to display additional content on top of what is already displayed.

This is a temporary solution which will be updated and embedded in a more structured customization system as a result of the work done for #165255.

The current solution creates already a context to allow granular consumption of the customizations only for those subtrees where a specific customization should apply.

The LogAIAssistant is used to customize the current LogExplorer as the first usage of this customization.

Screen.Recording.2023-11-07.at.15.14.05.mov

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@tonyghiani tonyghiani marked this pull request as ready for review November 7, 2023 14:23
@tonyghiani tonyghiani requested review from a team as code owners November 7, 2023 14:23
@tonyghiani tonyghiani added Team:obs-ux-logs Observability Logs User Experience Team Feature:LogsExplorer Logs Explorer feature labels Nov 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@tonyghiani tonyghiani added the release_note:skip Skip the PR/issue when compiling release notes label Nov 7, 2023
@tonyghiani
Copy link
Contributor Author

/oblt-cli

Copy link
Contributor

@achyutjhunjhunwala achyutjhunjhunwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work mate, 💯 LGTM

Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm deferring to @achyutjhunjhunwala's review. This is just to work around the stale code owner assignments.

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
logExplorer 475 476 +1
observabilityLogExplorer 128 130 +2
total +3

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
logExplorer 22 26 +4
logsShared 270 272 +2
total +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
logExplorer 201.1KB 200.3KB -780.0B

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
logExplorer 7 8 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
logExplorer 36.4KB 37.6KB +1.2KB
logsShared 220.0KB 220.2KB +209.0B
observabilityLogExplorer 31.1KB 31.5KB +419.0B
total +1.8KB
Unknown metric groups

API count

id before after diff
logExplorer 22 26 +4
logsShared 285 287 +2
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tonyghiani tonyghiani merged commit 43f9712 into elastic:main Nov 8, 2023
@tonyghiani tonyghiani deleted the 169506-flyout-details-ai-assistant-registration branch November 8, 2023 11:35
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Nov 8, 2023
@achyutjhunjhunwala achyutjhunjhunwala changed the title [Log Explorer] Flyout details ai assistant registration [Logs Explorer] Flyout details ai assistant registration Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:LogsExplorer Logs Explorer feature release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Log Explorer] Log Flyout AI assistant
8 participants