-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UnifiedFieldList] Add visual indicator to already selected fields #170623
Conversation
/ci |
💔 Build FailedFailed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Summary
Revolves #146063
this is a quick POC to add visual indication if a field has already been selected. In the #1460663 it's suggested to add a border to the selected fields. however due to recent changes this would cause issues with the vertical alignment of the fields (all elements need more padding on the left)
So in this PR another option is evaluated, to make already selected fields bolder
There might be a better way to indicate already selected fields? Open for discussion
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers