Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UnifiedFieldList] Add visual indicator to already selected fields #170623

Closed
wants to merge 12 commits into from

Conversation

kertal
Copy link
Member

@kertal kertal commented Nov 6, 2023

Summary

Revolves #146063

this is a quick POC to add visual indication if a field has already been selected. In the #1460663 it's suggested to add a border to the selected fields. however due to recent changes this would cause issues with the vertical alignment of the fields (all elements need more padding on the left)

Discover_-_Elastic

So in this PR another option is evaluated, to make already selected fields bolder

Bildschirmfoto 2024-01-12 um 12 15 41

There might be a better way to indicate already selected fields? Open for discussion

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@kertal kertal self-assigned this Nov 6, 2023
@kertal kertal added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:UnifiedFieldList The unified field list component used by Lens & Discover labels Nov 6, 2023
@kertal
Copy link
Member Author

kertal commented Jan 12, 2024

/ci

@kibana-ci
Copy link
Collaborator

kibana-ci commented Jan 12, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #2 / UnifiedFieldList FieldItemButton renders properly
  • [job] [logs] Jest Tests #2 / UnifiedFieldList FieldItemButton renders properly
  • [job] [logs] Jest Tests #2 / UnifiedFieldList FieldItemButton renders properly for Records (Lens field)
  • [job] [logs] Jest Tests #2 / UnifiedFieldList FieldItemButton renders properly for Records (Lens field)
  • [job] [logs] Jest Tests #2 / UnifiedFieldList FieldItemButton renders properly for search with spaces
  • [job] [logs] Jest Tests #2 / UnifiedFieldList FieldItemButton renders properly for search with spaces
  • [job] [logs] Jest Tests #2 / UnifiedFieldList FieldItemButton renders properly for text-based column field
  • [job] [logs] Jest Tests #2 / UnifiedFieldList FieldItemButton renders properly for text-based column field
  • [job] [logs] Jest Tests #2 / UnifiedFieldList FieldItemButton renders properly for wildcard search
  • [job] [logs] Jest Tests #2 / UnifiedFieldList FieldItemButton renders properly for wildcard search
  • [job] [logs] Jest Tests #2 / UnifiedFieldList FieldItemButton renders properly when a conflict field
  • [job] [logs] Jest Tests #2 / UnifiedFieldList FieldItemButton renders properly when a conflict field
  • [job] [logs] Jest Tests #2 / UnifiedFieldList FieldItemButton renders properly when empty
  • [job] [logs] Jest Tests #2 / UnifiedFieldList FieldItemButton renders properly when empty
  • [job] [logs] Jest Tests #2 / UnifiedFieldList FieldItemButton renders properly with a drag icon
  • [job] [logs] Jest Tests #2 / UnifiedFieldList FieldItemButton renders properly with a drag icon
  • [job] [logs] Jest Tests #2 / UnifiedFieldList FieldItemButton renders properly with an action when deselected
  • [job] [logs] Jest Tests #2 / UnifiedFieldList FieldItemButton renders properly with an action when deselected
  • [job] [logs] Jest Tests #2 / UnifiedFieldList FieldItemButton renders properly with an action when selected
  • [job] [logs] Jest Tests #2 / UnifiedFieldList FieldItemButton renders properly with an action when selected

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/react-field 9 10 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudSecurityPosture 413.6KB 413.8KB +208.0B
dataVisualizer 616.3KB 616.5KB +208.0B
discover 555.3KB 555.8KB +523.0B
enterpriseSearch 2.7MB 2.7MB +208.0B
eventAnnotationListing 196.6KB 196.8KB +208.0B
graph 387.1KB 387.3KB +208.0B
indexManagement 585.1KB 585.3KB +208.0B
lens 1.4MB 1.4MB +268.0B
logExplorer 981.7KB 981.9KB +208.0B
maps 2.9MB 2.9MB +208.0B
ml 3.6MB 3.6MB +208.0B
presentationUtil 82.1KB 82.3KB +208.0B
securitySolution 11.4MB 11.4MB +208.0B
stackAlerts 81.7KB 81.9KB +208.0B
unifiedDocViewer 58.4KB 58.6KB +208.0B
unifiedSearch 213.8KB 214.0KB +208.0B
total +3.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
osquery 51.2KB 51.4KB +208.0B
Unknown metric groups

API count

id before after diff
@kbn/react-field 22 23 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kertal @andreadelrio

@kertal kertal closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:collect-apm Feature:UnifiedFieldList The unified field list component used by Lens & Discover Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants