[8.11] [Cloud Security] set rowHeight to 0 to fix the bug of large row height in Findings (#170503) #170587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t in Findings (elastic#170503) ## Summary fixes - elastic#170502 defaulting to row height 0 for the findings table. As the default was -1 before, we were defaulting to 0, but due to this change https://github.com/elastic/kibana/pull/169724/files the default became 3, which broke our table. I guess the logic of taking the UI setting if it's differnt from default -1 was to cater for users changing the row height somewhere in the settings, but we need to bring to product/design to see if we want to support it --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 5b72f77)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @maxcold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.11:Questions ?
Please refer to the Backport tool documentation