Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make alerts table row to fit user profile avatars by default #170505

Conversation

e40pud
Copy link
Contributor

@e40pud e40pud commented Nov 3, 2023

Summary

Allow alerts table to render user avatars without cutting them off.

Broken:
Screenshot 2023-11-03 at 12 12 05

Fixed:
Screenshot 2023-11-03 at 12 11 52

Main ticket https://github.com/elastic/security-team/issues/2504

@e40pud e40pud added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. release_note:feature Makes this part of the condensed release notes Team:Detection Engine Security Solution Detection Engine Area labels Nov 3, 2023
@e40pud e40pud self-assigned this Nov 3, 2023
@e40pud e40pud requested a review from a team as a code owner November 3, 2023 11:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@e40pud e40pud merged commit 89ec60a into elastic:security/feature/alert-user-assignment Nov 3, 2023
5 checks passed
@e40pud e40pud deleted the security/feature/alert-user-assignment-row-height branch November 3, 2023 12:15
@kibana-ci
Copy link
Collaborator

kibana-ci commented Nov 3, 2023

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Cypress Tests #7 / Changing alert status Closing alerts Closes one alert when more than one opened alerts are selected Closes one alert when more than one opened alerts are selected
  • [job] [logs] Investigations - Security Solution Cypress Tests #7 / Changing alert status Closing alerts Closes one alert when more than one opened alerts are selected Closes one alert when more than one opened alerts are selected
  • [job] [logs] Investigations - Security Solution Cypress Tests #7 / Changing alert status Closing alerts Updates count table whenever alert status is updated in table Updates count table whenever alert status is updated in table
  • [job] [logs] Investigations - Security Solution Cypress Tests #7 / Changing alert status Closing alerts Updates count table whenever alert status is updated in table Updates count table whenever alert status is updated in table
  • [job] [logs] Investigations - Security Solution Cypress Tests #7 / Changing alert status Marking alerts as acknowledged Mark one alert as acknowledged when more than one open alerts are selected Mark one alert as acknowledged when more than one open alerts are selected
  • [job] [logs] Investigations - Security Solution Cypress Tests #7 / Changing alert status Marking alerts as acknowledged Mark one alert as acknowledged when more than one open alerts are selected Mark one alert as acknowledged when more than one open alerts are selected
  • [job] [logs] Investigations - Security Solution Cypress Tests #1 / Expandable flyout state sync should test flyout url sync should test flyout url sync
  • [job] [logs] Investigations - Security Solution Cypress Tests #1 / Expandable flyout state sync should test flyout url sync should test flyout url sync

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [34862d7]

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @e40pud

e40pud added a commit that referenced this pull request Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:feature Makes this part of the condensed release notes Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants