Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases] Fix flakiness in the description tests #170433

Merged
merged 5 commits into from
Nov 3, 2023
Merged

[Cases] Fix flakiness in the description tests #170433

merged 5 commits into from
Nov 3, 2023

Conversation

cnasikas
Copy link
Member

@cnasikas cnasikas commented Nov 2, 2023 •
edited
Loading

Summary

I substituted userEvent.type with userEvent.paste and it improved the performance a lot.

Before
Screenshot 2023-11-02 at 3 36 17 PM

After
Screenshot 2023-11-02 at 3 36 34 PM

Fixes: #164045, #164049, and #164048

I ran the tests 50 times on CI in f1a4551, 71190a2, 4908b0e

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.12.0 labels Nov 2, 2023
@cnasikas cnasikas self-assigned this Nov 2, 2023
@cnasikas
Copy link
Member Author

cnasikas commented Nov 2, 2023

@elasticmachine merge upstream

@cnasikas
Copy link
Member Author

cnasikas commented Nov 2, 2023

@elasticmachine merge upstream

This was linked to issues Nov 2, 2023
Failing test: Jest Tests.x-pack/plugins/cases/public/components/description - Description should hide the edit button when the user does not have update permissions #164049
Closed
Failing test: Jest Tests.x-pack/plugins/cases/public/components/description - Description shows an error when description is too long #164048
Closed
@cnasikas cnasikas marked this pull request as ready for review November 3, 2023 08:09
@cnasikas cnasikas requested a review from a team as a code owner November 3, 2023 08:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

js-jankisalvi
js-jankisalvi approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@js-jankisalvi js-jankisalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

adcoelho
adcoelho approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@adcoelho adcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

@cnasikas cnasikas added the release_note:skip Skip the PR/issue when compiling release notes label Nov 3, 2023
@cnasikas cnasikas merged commit 9c26527 into elastic:main Nov 3, 2023
2 checks passed
@cnasikas cnasikas deleted the fix_flaky_description branch November 3, 2023 09:03
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js-jankisalvi js-jankisalvi js-jankisalvi approved these changes

@adcoelho adcoelho adcoelho approved these changes

Assignees

@cnasikas cnasikas

Labels
backport:skip This commit does not require backporting Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.0
Projects
None yet
Milestone
No milestone
6 participants
@cnasikas @elasticmachine @kibana-ci @adcoelho @js-jankisalvi @kibanamachine