[Cases] Create internal API to filter cases by custom fields #170297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js-jankisalvi
added
Team:ResponseOps
js-jankisalvi
added
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
adcoelho
approved these changes
Nov 9, 2023
…isalvi/kibana into filter-custom-fields-api
cnasikas
reviewed
Nov 10, 2023
x-pack/test/cases_api_integration/security_and_spaces/tests/common/internal/search_cases.ts
Outdated
Show resolved
Hide resolved
cnasikas
changed the title
cnasikas
changed the title
cnasikas
reviewed
Nov 13, 2023
x-pack/test/cases_api_integration/security_and_spaces/tests/common/internal/search_cases.ts
Outdated
Show resolved
Hide resolved
x-pack/test/cases_api_integration/security_and_spaces/tests/common/internal/search_cases.ts
Outdated
Show resolved
Hide resolved
cnasikas
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Great work @js-jankisalvi 🚀 ! Thank you for your patience with the review.
Comment on lines
75
to
83
| if (!paramArgs.owner || !paramArgs.owner.length) { | ||
| throw Boom.badRequest('In order to filter cases by customFields, you must provide owner.'); | ||
| } | ||
|
|
||
| if (isArray(paramArgs.owner) && paramArgs.owner.length > 1) { | ||
| throw Boom.badRequest( | ||
| 'In order to filter cases by customFields, you must provide only one owner.' | ||
| ); | ||
| } |
There was a problem hiding this comment.
What do you think of combining the two messages?
if (isArray(paramArgs.owner) && paramArgs.owner.length > 1) {
throw Boom.badRequest(
'Owner must be provided. Multiple owners are not supported.'
);
}
| * throw error if request body does not have owner | ||
| */ | ||
| if (!Object.hasOwn(options, 'owner')) { | ||
| throw Boom.badRequest('Search cases must have a valid owner.'); |
There was a problem hiding this comment.
nit: What about Owner is required.
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements #167740
This PR
search_casesinternal route with POSTexample of search cases body:
{ "customFields": { "custom_field_key": [true] } }Checklist
For maintainers