Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Add information on KQL filtering in APM rules #170257

Merged
merged 3 commits into from
Nov 2, 2023
Merged

[DOCS] Add information on KQL filtering in APM rules #170257

merged 3 commits into from
Nov 2, 2023

Conversation

colleenmcginnis
Copy link
Contributor

@colleenmcginnis colleenmcginnis commented Oct 31, 2023 •
edited by kibanamachine
Loading

Closes elastic/observability-docs#3160

Summary

Adds information on KQL filtering in APM rules.

Checklist

@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@colleenmcginnis colleenmcginnis self-assigned this Oct 31, 2023
@colleenmcginnis colleenmcginnis added release_note:skip Skip the PR/issue when compiling release notes docs v8.11.0 labels Oct 31, 2023
@benakansara
Copy link
Contributor

@colleenmcginnis It was added in 8.10

benakansara
benakansara reviewed Nov 1, 2023
View reviewed changes
Copy link
Contributor

@benakansara benakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text changes LGTM.
Are we updating screenshots as well? Let me know if you need new screenshots.

benakansara
benakansara requested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@benakansara benakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment above.

@colleenmcginnis
Copy link
Contributor Author

colleenmcginnis commented Nov 1, 2023 •
edited
Loading

Should we also add "Latency threshold" to the list at the top of this page? Something like:

* Latency threshold: Alert when the latency of a specific transaction type in a service exceeds a defined threshold.

@colleenmcginnis
Copy link
Contributor Author

Oh ignore that last comment. I see that the latency and failed transaction rate threshold rules are combined in that list.

bmorelli25
bmorelli25 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my perspective!

benakansara
benakansara approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@benakansara benakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colleenmcginnis colleenmcginnis merged commit e5bb85b into elastic:main Nov 2, 2023
@colleenmcginnis colleenmcginnis deleted the obs-docs-issue-3160 branch November 2, 2023 14:29
@kibanamachine kibanamachine mentioned this pull request Nov 2, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 2, 2023
@colleenmcginnis
[DOCS] Add information on KQL filtering in APM rules (elastic#170257)
a803278 
Closes elastic/observability-docs#3160

## Summary

Adds information on KQL filtering in APM rules.

### Checklist

- [x] @colleenmcginnis initial draft
- [x] @benakansara review
    * In what version was this initially added? 8.10.0?
- [ ] @colleenmcginnis address feedback, merge

(cherry picked from commit e5bb85b)
@kibanamachine kibanamachine mentioned this pull request Nov 2, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 2, 2023
@colleenmcginnis
[DOCS] Add information on KQL filtering in APM rules (elastic#170257)
60655aa 
Closes elastic/observability-docs#3160

## Summary

Adds information on KQL filtering in APM rules.

### Checklist

- [x] @colleenmcginnis initial draft
- [x] @benakansara review
    * In what version was this initially added? 8.10.0?
- [ ] @colleenmcginnis address feedback, merge

(cherry picked from commit e5bb85b)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.10
✅ 8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 2, 2023
@kibanamachine @colleenmcginnis
[8.10] [DOCS] Add information on KQL filtering in APM rules (#170257) (…
612b62b 
…#170425)

# Backport

This will backport the following commits from `main` to `8.10`:
- [[DOCS] Add information on KQL filtering in APM rules
(#170257)](#170257)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Colleen
McGinnis","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-02T14:29:54Z","message":"[DOCS]
Add information on KQL filtering in APM rules (#170257)\n\nCloses
https://github.com/elastic/observability-docs/issues/3160\r\n\r\n##
Summary\r\n\r\nAdds information on KQL filtering in APM
rules.\r\n\r\n### Checklist\r\n\r\n- [x] @colleenmcginnis initial
draft\r\n- [x] @benakansara review\r\n * In what version was this
initially added? 8.10.0?\r\n- [ ] @colleenmcginnis address feedback,
merge","sha":"e5bb85b4b3319f0c7d50276b48bf0759a60ca95c","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","docs","v8.10.0","v8.11.0","v8.12.0"],"number":170257,"url":"https://github.com/elastic/kibana/pull/170257","mergeCommit":{"message":"[DOCS]
Add information on KQL filtering in APM rules (#170257)\n\nCloses
https://github.com/elastic/observability-docs/issues/3160\r\n\r\n##
Summary\r\n\r\nAdds information on KQL filtering in APM
rules.\r\n\r\n### Checklist\r\n\r\n- [x] @colleenmcginnis initial
draft\r\n- [x] @benakansara review\r\n * In what version was this
initially added? 8.10.0?\r\n- [ ] @colleenmcginnis address feedback,
merge","sha":"e5bb85b4b3319f0c7d50276b48bf0759a60ca95c"}},"sourceBranch":"main","suggestedTargetBranches":["8.10","8.11"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170257","number":170257,"mergeCommit":{"message":"[DOCS]
Add information on KQL filtering in APM rules (#170257)\n\nCloses
https://github.com/elastic/observability-docs/issues/3160\r\n\r\n##
Summary\r\n\r\nAdds information on KQL filtering in APM
rules.\r\n\r\n### Checklist\r\n\r\n- [x] @colleenmcginnis initial
draft\r\n- [x] @benakansara review\r\n * In what version was this
initially added? 8.10.0?\r\n- [ ] @colleenmcginnis address feedback,
merge","sha":"e5bb85b4b3319f0c7d50276b48bf0759a60ca95c"}}]}] BACKPORT-->

Co-authored-by: Colleen McGinnis <[email protected]>
kibanamachine added a commit that referenced this pull request Nov 2, 2023
@kibanamachine @colleenmcginnis
[8.11] [DOCS] Add information on KQL filtering in APM rules (#170257) (…
dc456b5 
…#170426)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[DOCS] Add information on KQL filtering in APM rules
(#170257)](#170257)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Colleen
McGinnis","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-02T14:29:54Z","message":"[DOCS]
Add information on KQL filtering in APM rules (#170257)\n\nCloses
https://github.com/elastic/observability-docs/issues/3160\r\n\r\n##
Summary\r\n\r\nAdds information on KQL filtering in APM
rules.\r\n\r\n### Checklist\r\n\r\n- [x] @colleenmcginnis initial
draft\r\n- [x] @benakansara review\r\n * In what version was this
initially added? 8.10.0?\r\n- [ ] @colleenmcginnis address feedback,
merge","sha":"e5bb85b4b3319f0c7d50276b48bf0759a60ca95c","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","docs","v8.10.0","v8.11.0","v8.12.0"],"number":170257,"url":"https://github.com/elastic/kibana/pull/170257","mergeCommit":{"message":"[DOCS]
Add information on KQL filtering in APM rules (#170257)\n\nCloses
https://github.com/elastic/observability-docs/issues/3160\r\n\r\n##
Summary\r\n\r\nAdds information on KQL filtering in APM
rules.\r\n\r\n### Checklist\r\n\r\n- [x] @colleenmcginnis initial
draft\r\n- [x] @benakansara review\r\n * In what version was this
initially added? 8.10.0?\r\n- [ ] @colleenmcginnis address feedback,
merge","sha":"e5bb85b4b3319f0c7d50276b48bf0759a60ca95c"}},"sourceBranch":"main","suggestedTargetBranches":["8.10","8.11"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/170257","number":170257,"mergeCommit":{"message":"[DOCS]
Add information on KQL filtering in APM rules (#170257)\n\nCloses
https://github.com/elastic/observability-docs/issues/3160\r\n\r\n##
Summary\r\n\r\nAdds information on KQL filtering in APM
rules.\r\n\r\n### Checklist\r\n\r\n- [x] @colleenmcginnis initial
draft\r\n- [x] @benakansara review\r\n * In what version was this
initially added? 8.10.0?\r\n- [ ] @colleenmcginnis address feedback,
merge","sha":"e5bb85b4b3319f0c7d50276b48bf0759a60ca95c"}}]}] BACKPORT-->

Co-authored-by: Colleen McGinnis <[email protected]>
delanni pushed a commit to delanni/kibana that referenced this pull request Nov 6, 2023
@colleenmcginnis @delanni
[DOCS] Add information on KQL filtering in APM rules (elastic#170257)
dbe1817 
Closes elastic/observability-docs#3160

## Summary

Adds information on KQL filtering in APM rules.

### Checklist

- [x] @colleenmcginnis initial draft
- [x] @benakansara review
    * In what version was this initially added? 8.10.0?
- [ ] @colleenmcginnis address feedback, merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benakansara benakansara benakansara approved these changes

@bmorelli25 bmorelli25 bmorelli25 approved these changes

Assignees

@colleenmcginnis colleenmcginnis

Labels
docs release_note:skip Skip the PR/issue when compiling release notes v8.10.0 v8.10.5 v8.11.0 v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REQUEST]: KQL Filtering in APM rules
5 participants
@colleenmcginnis @apmmachine @benakansara @kibanamachine @bmorelli25