Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security solution] AI connector changes #170150

Merged
merged 3 commits into from
Oct 30, 2023
Merged

[Security solution] AI connector changes #170150

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8ab8c9
changes
stephmilovic Oct 30, 2023
6f67b9f
add comment
stephmilovic Oct 30, 2023
3e73eb7
test fixed
stephmilovic Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions x-pack/plugins/stack_connectors/server/connector_types/bedrock/bedrock.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ export class BedrockConnector extends SubActionConnector<Config, Secrets> {
},
body,
path,
service: 'bedrock',
},
{
secretAccessKey: this.secrets.secret,
Expand Down
2 changes: 2 additions & 0 deletions x-pack/plugins/stack_connectors/server/connector_types/openai/openai.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ export class OpenAIConnector extends SubActionConnector<Config, Secrets> {
method: 'post',
responseSchema: RunActionResponseSchema,
data: sanitizedBody,
// give up to 2 minutes for response
timeout: 120000,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried this in practice? The thing I'm worrying about is that task manager could potentially "kill" the task if it hit's IT's timeout limit - which I believe can be extended but will need to look up how ...

TM can't really kill a task, but will basically ignore it if it runs over it's time-limit, and would then generate some kind of warning / error. And potentially retry it, but I believe it doesn't today ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this issue #166561

Copy link
Contributor Author

@stephmilovic stephmilovic Oct 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tried this in practice?

We already have this length timeout on bedrock. @jamesspi has been running into issues with OpenAI not having enough time, and has been using Bedrock because it allows the extra time

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also see this issue! https://github.com/elastic/security-team/issues/7873

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the default task timeout is 5 minutes and I don't think we set a custom timeout for action tasks so this shouldn't be cancelled due to timeout

...axiosOptions,
});
return response.data;
Expand Down