Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs Explorer] Add support for log generation in synthtrace #170107

Conversation

achyutjhunjhunwala
Copy link
Contributor

@achyutjhunjhunwala achyutjhunjhunwala commented Oct 30, 2023

Closes - #170133

Summary

This PR adds support for generating logs using the Synthtrace Client

Changes include

  1. Changes to Synthtrace package to support new Logs Client and Log Class for helper methods
  2. [Stateful Tests] - Change to our FTR Context config to inject the new the Log Synthtrace Client
  3. [Serverless Tests] - Injected Synthtrace as a service for serverless tests.
  4. A sample test added to app.ts to demonstrate how Synthtrace can be used to generate Log data in both Stateful and Serverless
  5. Add support to generate logs via CLI. 2 scenarios added - simple_logs.ts and logs_and_metrics.ts
# Live Data
node scripts/synthtrace simple_logs.ts --clean --live

# Static Data
node scripts/synthtrace simple_logs.ts --clean

@achyutjhunjhunwala achyutjhunjhunwala self-assigned this Oct 30, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@achyutjhunjhunwala achyutjhunjhunwala added Team:obs-ux-logs Observability Logs User Experience Team release_note:skip Skip the PR/issue when compiling release notes labels Oct 30, 2023
@achyutjhunjhunwala achyutjhunjhunwala marked this pull request as ready for review October 30, 2023 14:03
@achyutjhunjhunwala achyutjhunjhunwala requested review from a team as code owners October 30, 2023 14:03
@botelastic botelastic bot added the Team:APM All issues that need APM UI Team support label Oct 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@@ -39,8 +39,8 @@ packages/analytics/shippers/gainsight @elastic/kibana-core
packages/kbn-apm-config-loader @elastic/kibana-core @vigneshshanmugam
x-pack/plugins/apm_data_access @elastic/obs-knowledge-team @elastic/obs-ux-infra_services-team
x-pack/plugins/apm @elastic/obs-ux-infra_services-team
packages/kbn-apm-synthtrace @elastic/obs-ux-infra_services-team
packages/kbn-apm-synthtrace-client @elastic/obs-ux-infra_services-team
packages/kbn-apm-synthtrace @elastic/obs-ux-infra_services-team @elastic/obs-ux-logs-team
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, multiple codeowners means multiple approvals. do we want this?

Copy link
Contributor Author

@achyutjhunjhunwala achyutjhunjhunwala Nov 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, i want to keep myself in loop for future changes to this repo. Hence added my current team, also I can pull you in when a complicated code requires review as you are not in any of the current owner teams😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also fine removing the @elastic/obs-ux-infra_services-team

Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing @achyutjhunjhunwala 🎩
Looking forward to use synthtrace with Logs 🎉

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/apm-synthtrace 31 34 +3
@kbn/apm-synthtrace-client 181 184 +3
total +6

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/apm-synthtrace 7 8 +1
Unknown metric groups

API count

id before after diff
@kbn/apm-synthtrace 31 34 +3
@kbn/apm-synthtrace-client 181 184 +3
total +6

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @achyutjhunjhunwala

@achyutjhunjhunwala achyutjhunjhunwala merged commit db5176b into elastic:main Nov 16, 2023
@achyutjhunjhunwala achyutjhunjhunwala deleted the add-support-for-logs-in-synthtrace branch November 16, 2023 13:00
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Nov 16, 2023
@smith smith removed the apm:review label Nov 16, 2023
@achyutjhunjhunwala achyutjhunjhunwala changed the title [Log Explorer] Add support for log generation in synthtrace [Logs Explorer] Add support for log generation in synthtrace Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:APM All issues that need APM UI Team support Team:obs-ux-logs Observability Logs User Experience Team v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.