-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Logs Explorer] Add support for log generation in synthtrace #170107
[Logs Explorer] Add support for log generation in synthtrace #170107
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Pinging @elastic/apm-ui (Team:APM) |
packages/kbn-apm-synthtrace/src/lib/logs/logs_synthtrace_es_client.ts
Outdated
Show resolved
Hide resolved
@@ -39,8 +39,8 @@ packages/analytics/shippers/gainsight @elastic/kibana-core | |||
packages/kbn-apm-config-loader @elastic/kibana-core @vigneshshanmugam | |||
x-pack/plugins/apm_data_access @elastic/obs-knowledge-team @elastic/obs-ux-infra_services-team | |||
x-pack/plugins/apm @elastic/obs-ux-infra_services-team | |||
packages/kbn-apm-synthtrace @elastic/obs-ux-infra_services-team | |||
packages/kbn-apm-synthtrace-client @elastic/obs-ux-infra_services-team | |||
packages/kbn-apm-synthtrace @elastic/obs-ux-infra_services-team @elastic/obs-ux-logs-team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, multiple codeowners means multiple approvals. do we want this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH, i want to keep myself in loop for future changes to this repo. Hence added my current team, also I can pull you in when a complicated code requires review as you are not in any of the current owner teams😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am also fine removing the @elastic/obs-ux-infra_services-team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing @achyutjhunjhunwala 🎩
Looking forward to use synthtrace with Logs 🎉
packages/kbn-apm-synthtrace/src/cli/utils/start_live_data_upload.ts
Outdated
Show resolved
Hide resolved
packages/kbn-apm-synthtrace/src/cli/utils/start_live_data_upload.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Yngrid Coello <[email protected]>
packages/kbn-apm-synthtrace/src/lib/logs/logs_synthtrace_es_client.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Public APIs missing exports
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
Closes - #170133
Summary
This PR adds support for generating logs using the Synthtrace Client
Changes include
app.ts
to demonstrate how Synthtrace can be used to generate Log data in both Stateful and Serverlesssimple_logs.ts
andlogs_and_metrics.ts