-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Endpoint] several refactors of CLI tooling and associated common services #169987
[Security Solution][Endpoint] several refactors of CLI tooling and associated common services #169987
Conversation
…reateToolingLogger`
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
||
export class FleetManager extends Manager { | ||
private fleetContainerId?: string; | ||
private log: ToolingLog; | ||
private fleetServer: StartedFleetServer | undefined = undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: In the future, we may want to consider removing this module and replacing it with env.WITH_FLEET_SERVER
in the Cypress config file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/dev/precommit_hook/casing_check_config.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Summary
PR makes a series of refactors to CLI scripts and common services used in CLI scripts and CI, including:
endpoint_agent_runner
(CLI script) private implementation methods from Cypress and replace them with calls to common servicesendpoint_agent_runner
CLI script and replace it with calls to common servicesrun_sentinelone_host.js
script so that it also ensures that the SentinenlOne fleet integration/policy (agentless policy) has at least one VM host running"Stack Management > Connectors"
WITH_FLEET_SERVER
to the Cypress config. When set totrue
, fleet server will be automatically started and connected to the stack