Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.11] [Security Solution][DE] Migrate investigation_fields (#169061) #169957

Merged
merged 11 commits into from
Oct 27, 2023
Merged

[8.11] [Security Solution][DE] Migrate investigation_fields (#169061) #169957

merged 11 commits into from
Oct 27, 2023

Conversation

yctercero
Copy link
Contributor

Backport

This will backport the following commits from main to 8.11:

Questions ?

Please refer to the Backport tool documentation

@yctercero
[Security Solution][DE] Migrate investigation_fields (elastic#169061)
cbebeb1 
## Summary

**TLDR:** SO will support both `string[]` and `{ field_names: string[]
}`, but detection engine APIs will only support the object format in
8.11+.

(cherry picked from commit bb3673f)

# Conflicts:
#	x-pack/test/detection_engine_api_integration/security_and_spaces/group1/create_rule_exceptions.ts
#	x-pack/test/security_solution_api_integration/test_suites/detections_response/utils/index.ts
#	x-pack/test/security_solution_api_integration/tsconfig.json
@yctercero yctercero enabled auto-merge (squash) October 26, 2023 15:58
@yctercero yctercero mentioned this pull request Oct 26, 2023
Merged
1 task
@yctercero
Copy link
Contributor Author

@elasticmachine merge upstream

@yctercero
Copy link
Contributor Author

@elasticmachine merge upstream

@yctercero
Copy link
Contributor Author

@elasticmachine merge upstream

@yctercero
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Oct 27, 2023 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Cypress Tests #7 / Detections : Page Filters Impact of inputs "after each" hook for "should take kqlQuery into account" "after each" hook for "should take kqlQuery into account"
  • [job] [logs] Investigations - Security Solution Cypress Tests #7 / Detections : Page Filters Impact of inputs should take kqlQuery into account should take kqlQuery into account
  • [job] [logs] Security Solution Cypress Tests #9 / Ransomware Detection Alerts Ransomware in Timelines Renders ransomware entries in timelines table Renders ransomware entries in timelines table

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.0MB 13.0MB +110.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yctercero yctercero merged commit b3385d5 into elastic:8.11 Oct 27, 2023
1 check passed
@yctercero yctercero deleted the backport/8.11/pr-169061 branch October 27, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximpn maximpn maximpn approved these changes

Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yctercero @kibana-ci @maximpn @kibanamachine