-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SLO] Alerts embeddable #169910
[SLO] Alerts embeddable #169910
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
7399016
to
8a1830e
Compare
8a1830e
to
4f6dbe7
Compare
…-ref HEAD~1..HEAD --fix'
…-ref HEAD~1..HEAD --fix'
a761ea8
to
5a59d64
Compare
…have to mock it in my tests
…ta/kibana into slo_embeddable_alerts_table
@XavierM we have addressed all of your feedback, i don't think there is anything blocking anymore. Please give it another round of review. |
@shahzad31 did you also fix that? |
Yes both have been accounted for.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shahzad31 Can you make the changes we discussed for the query.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM... Tested multiple SLOs with the same instanceId to ensure they don't show up in the wrong visualization. The changes on the Overview side look good to.
…eddable_alerts_table
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM => Everything is working as expected
I was able to search for different SLO configuration. I can also refresh the embeddable alert table from a dashboard. And the query to access alert from an SLO is working like a charm.
Thank you for bearing with me <3, I tried be more diligent in my testing now that main can be push at anytime in server-less.
…eddable_alerts_table
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Canvas Sharable Runtime
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @mgiota |
Something doesn't work well for me with the slo selection Screen.Recording.2023-12-05.at.19.14.41.mov |
I restarted ES and issue is not reproducible any more. |
/oblt-deploy-serverless |
Resolves #171354
Resolves #170613
Resoves #172274
Resolves #172453
This PR adds the shareable Alerts table from the Response Ops team as an embeddable to the Dashboard app.
status
,rule name
,duration
,reason
. Actions column is hidden.Stack Management > Reporting
works fine without any timeout errorScreen.Recording.2023-11-21.at.12.02.03.mov
🗒️ Notes for the reviewer
There are a few issues with the current integration of the sharable alerts table, that I will fix as a separate PR: