Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Slack api allowed channels #169706

Merged
merged 3 commits into from
Nov 3, 2023
Merged

[DOCS] Slack api allowed channels #169706

merged 3 commits into from
Nov 3, 2023

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 24, 2023 •
edited by kibanamachine
Loading

Summary

Relates to #167150

This PR:

  • Refreshes automated slack-api-connector.png screenshot, since there is a new channel IDs field.
  • Removes the automated slack-api-params.png screenshot, since it requires valid channel IDs to generate.
  • Updates Slack connector docs to use automated slack-webhook-params.png screenshot instead
  • Updates Slack connector docs to describe the new behaviour

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.11.0 v8.12.0 labels Oct 24, 2023
@github-actions
Copy link
Contributor

Documentation preview:

@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Osquery Cypress Tests #1 / ALL - Add Integration Add and upgrade integration "after each" hook for "should add the old integration and be able to upgrade it" "after each" hook for "should add the old integration and be able to upgrade it"
  • [job] [logs] Serverless Osquery Cypress Tests #1 / ALL - Add Integration Add and upgrade integration should add the old integration and be able to upgrade it should add the old integration and be able to upgrade it
  • [job] [logs] Security Solution Cypress Tests #9 / Changing alert status Opening alerts can bulk open alerts can bulk open alerts

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl marked this pull request as ready for review October 24, 2023 22:50
@lcawl lcawl requested a review from a team as a code owner October 24, 2023 22:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@lcawl lcawl requested a review from XavierM October 26, 2023 22:32
@lcawl lcawl merged commit 8716f65 into elastic:main Nov 3, 2023
16 checks passed
@lcawl lcawl deleted the slack-channels branch November 3, 2023 18:38
lcawl added a commit to lcawl/kibana that referenced this pull request Nov 3, 2023
@lcawl
[DOCS] Slack api allowed channels (elastic#169706)
4bc06ef 
(cherry picked from commit 8716f65)
@lcawl lcawl mentioned this pull request Nov 3, 2023
Merged
@lcawl
Copy link
Contributor Author

lcawl commented Nov 3, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Nov 6, 2023
@lcawl
[8.11] [DOCS] Slack api allowed channels (#169706) (#170572)
1dfec34 
# Backport

This will backport the following commits from `main` to `8.11`:
- [[DOCS] Slack api allowed channels
(#169706)](#169706)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Lisa
Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-11-03T18:37:56Z","message":"[DOCS]
Slack api allowed channels
(#169706)","sha":"8716f659227a60e468fa61a4dec4c38df4174039","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","docs","Feature:Actions/ConnectorTypes","backport:prev-minor","v8.11.0","v8.12.0"],"number":169706,"url":"https://github.com/elastic/kibana/pull/169706","mergeCommit":{"message":"[DOCS]
Slack api allowed channels
(#169706)","sha":"8716f659227a60e468fa61a4dec4c38df4174039"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169706","number":169706,"mergeCommit":{"message":"[DOCS]
Slack api allowed channels
(#169706)","sha":"8716f659227a60e468fa61a4dec4c38df4174039"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) docs Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.11.0 v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lcawl @apmmachine @kibana-ci @elasticmachine @XavierM