Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Unskip tests for detection_response Cypress tests and enable Serverless run #169218

Merged
merged 7 commits into from
Oct 24, 2023

Conversation

jpdjere
Copy link
Contributor

@jpdjere jpdjere commented Oct 18, 2023

Summary

Flaky test runner for Cypress tests in:

  • x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_alerts
  • x-pack/test/security_solution_cypress/cypress/e2e/detection_response/value_lists
  • x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation

Changes

  • x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/custom_query_rule_data_view.cy.ts tagged to run on Serverless
  • x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/event_correlation_rule.cy.ts tagged to run on Serverless
  • x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/machine_learning_rule.cy.ts tagged to run on Serverless
  • x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/new_terms_rule.cy.ts tagged to run on Serverless
  • x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/override.cy.ts tagged to run on Serverless
  • x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/rule_actions/deletion/rule_delete.cy.ts added disableAutorefresh() to avoid flakiness

Related failing-test issues

detection_response/detection_alerts

  1. Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_alerts/alert_status·cy·ts - Changing alert status Opening alerts can bulk open alerts can bulk open alerts #169091
    Marked as legit-flake and assigned to @elastic/security-detection-engine
  2. Failing test: Security Solution Cypress.x-pack/plugins/security_solution/cypress/e2e/detection_alerts/missing_privileges_callout·cy·ts - Detections > Callouts indicating read-only access to resources On Rule Details page When a user clicks Dismiss on the callouts We hide them and persist the dismissal We hide them and persist the dismissal #163885

detection_response/value_lists

  1. Failing test: Security Solution Cypress.x-pack/test/security_solution_cypress/cypress/e2e/detection_response/value_lists/value_lists·cy·ts - value lists management modal "before each" hook for "can open and close the modal" "before each" hook for "can open and close the modal" #165699

detection_response/rule_creation

  1. Failing test: Security Solution Cypress.x-pack/plugins/security_solution/cypress/e2e/detection_response/rule_creation/custom_query_rule·cy·ts - Custom query rules Custom detection rules creation Creates and enables a new rule Creates and enables a new rule #163691

Flaky test runner

@jpdjere jpdjere requested a review from a team as a code owner October 18, 2023 10:27
@jpdjere jpdjere marked this pull request as draft October 19, 2023 09:06
@jpdjere jpdjere force-pushed the flaky-test-runner-detections-response branch from 2ad6815 to 324b69e Compare October 23, 2023 14:20
@jpdjere jpdjere force-pushed the flaky-test-runner-detections-response branch from 324b69e to 261ffd5 Compare October 23, 2023 14:21
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

  • 💔 Build #169879 failed 83a1031afd0e9377266b6021935deb33cb89d379
  • 💔 Build #169845 failed c9b7089de5f3d322c5c1a96e26aad3c334a7f111
  • 💔 Build #169377 failed 5820130e1f87ae9f1428bfc9eab519db9bd6eb91
  • 💛 Build #168957 was flaky a80c914a777d95bb4d907f305abbf9f2fde98050

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jpdjere jpdjere self-assigned this Oct 23, 2023
@jpdjere jpdjere added release_note:skip Skip the PR/issue when compiling release notes Team:Detections and Resp Security Detection Response Team Team:Detection Rule Management Security Detection Rule Management Team Team:Detection Engine Security Solution Detection Engine Area v8.12.0 labels Oct 23, 2023
@jpdjere jpdjere marked this pull request as ready for review October 23, 2023 20:51
@jpdjere jpdjere requested a review from a team as a code owner October 23, 2023 20:51
@jpdjere jpdjere requested a review from nikitaindik October 23, 2023 20:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@jpdjere jpdjere changed the title [Security Solution] Flaky test runner for detection_response Cypress tests [Security Solution] Unskip tests for detection_response Cypress tests and enable Serverless run Oct 23, 2023
@jpdjere jpdjere requested review from maximpn and removed request for nikitaindik October 23, 2023 21:10
Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detection engine changes LGTM - thank you!

Copy link
Contributor

@maximpn maximpn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maximpn maximpn merged commit 939c87d into elastic:main Oct 24, 2023
10 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 24, 2023
@jpdjere jpdjere deleted the flaky-test-runner-detections-response branch October 24, 2023 08:25
@jpdjere
Copy link
Contributor Author

jpdjere commented Oct 24, 2023

💚 All backports created successfully

Status Branch Result
8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jpdjere added a commit to jpdjere/kibana that referenced this pull request Oct 24, 2023
…ts and enable Serverless run (elastic#169218)

## Summary

Flaky test runner for Cypress tests in:
- `x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_alerts`
- `x-pack/test/security_solution_cypress/cypress/e2e/detection_response/value_lists`
- `x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation`

## Changes

- `x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/custom_query_rule_data_view.cy.ts` **tagged to run on Serverless**
- `x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/event_correlation_rule.cy.ts` **tagged to run on Serverless**
- `x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/machine_learning_rule.cy.ts` **tagged to run on Serverless**
- `x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/new_terms_rule.cy.ts` **tagged to run on Serverless**
- `x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/override.cy.ts`  **tagged to run on Serverless**
- `x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/rule_actions/deletion/rule_delete.cy.ts` **added disableAutorefresh() to avoid flakiness**

## Related failing-test issues

### `detection_response/detection_alerts`
1. elastic#169091
**Marked as `legit-flake` and assigned to @elastic/security-detection-engine**
3. elastic#163885

### `detection_response/value_lists`
4. elastic#165699

### `detection_response/rule_creation`
5. elastic#163691

## Flaky test runner

- https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3583
- https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3615 [SERVERLESS ONLY]
- https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3656 [Serverless without indicator match and saved queries]

(cherry picked from commit 939c87d)
jpdjere added a commit that referenced this pull request Oct 26, 2023
…ess tests and enable Serverless run (#169218) (#169681)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[Security Solution] Unskip tests for `detection_response` Cypress
tests and enable Serverless run
(#169218)](#169218)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Juan Pablo
Djeredjian","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-24T07:18:42Z","message":"[Security
Solution] Unskip tests for `detection_response` Cypress tests and enable
Serverless run (#169218)\n\n## Summary\r\n\r\nFlaky test runner for
Cypress tests in:\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_alerts`
\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/value_lists`
\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation`
\r\n\r\n## Changes\r\n\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/custom_query_rule_data_view.cy.ts`
**tagged to run on Serverless**\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/event_correlation_rule.cy.ts`
**tagged to run on Serverless**\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/machine_learning_rule.cy.ts`
**tagged to run on Serverless**\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/new_terms_rule.cy.ts`
**tagged to run on Serverless**\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/override.cy.ts`
**tagged to run on Serverless**\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/rule_actions/deletion/rule_delete.cy.ts`
**added disableAutorefresh() to avoid flakiness**\r\n\r\n## Related
failing-test issues\r\n\r\n###
`detection_response/detection_alerts`\r\n1.
https://github.com/elastic/kibana/issues/169091\r\n**Marked as
`legit-flake` and assigned to @elastic/security-detection-engine**
\r\n3. https://github.com/elastic/kibana/issues/163885\r\n\r\n###
`detection_response/value_lists`\r\n4.
https://github.com/elastic/kibana/issues/165699\r\n\r\n###
`detection_response/rule_creation`\r\n5.
https://github.com/elastic/kibana/issues/163691\r\n\r\n## Flaky test
runner\r\n\r\n-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3583\r\n-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3615
[SERVERLESS ONLY]\r\n-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3656
[Serverless without indicator match and saved
queries]","sha":"939c87d95342c61f03c853cb3b34c9f412c303b0","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","Team:Detections
and Resp","Team:Detection Rule Management","Team:Detection
Engine","v8.12.0"],"number":169218,"url":"https://github.com/elastic/kibana/pull/169218","mergeCommit":{"message":"[Security
Solution] Unskip tests for `detection_response` Cypress tests and enable
Serverless run (#169218)\n\n## Summary\r\n\r\nFlaky test runner for
Cypress tests in:\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_alerts`
\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/value_lists`
\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation`
\r\n\r\n## Changes\r\n\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/custom_query_rule_data_view.cy.ts`
**tagged to run on Serverless**\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/event_correlation_rule.cy.ts`
**tagged to run on Serverless**\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/machine_learning_rule.cy.ts`
**tagged to run on Serverless**\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/new_terms_rule.cy.ts`
**tagged to run on Serverless**\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/override.cy.ts`
**tagged to run on Serverless**\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/rule_actions/deletion/rule_delete.cy.ts`
**added disableAutorefresh() to avoid flakiness**\r\n\r\n## Related
failing-test issues\r\n\r\n###
`detection_response/detection_alerts`\r\n1.
https://github.com/elastic/kibana/issues/169091\r\n**Marked as
`legit-flake` and assigned to @elastic/security-detection-engine**
\r\n3. https://github.com/elastic/kibana/issues/163885\r\n\r\n###
`detection_response/value_lists`\r\n4.
https://github.com/elastic/kibana/issues/165699\r\n\r\n###
`detection_response/rule_creation`\r\n5.
https://github.com/elastic/kibana/issues/163691\r\n\r\n## Flaky test
runner\r\n\r\n-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3583\r\n-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3615
[SERVERLESS ONLY]\r\n-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3656
[Serverless without indicator match and saved
queries]","sha":"939c87d95342c61f03c853cb3b34c9f412c303b0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169218","number":169218,"mergeCommit":{"message":"[Security
Solution] Unskip tests for `detection_response` Cypress tests and enable
Serverless run (#169218)\n\n## Summary\r\n\r\nFlaky test runner for
Cypress tests in:\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/detection_alerts`
\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/value_lists`
\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation`
\r\n\r\n## Changes\r\n\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/custom_query_rule_data_view.cy.ts`
**tagged to run on Serverless**\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/event_correlation_rule.cy.ts`
**tagged to run on Serverless**\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/machine_learning_rule.cy.ts`
**tagged to run on Serverless**\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/new_terms_rule.cy.ts`
**tagged to run on Serverless**\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_creation/override.cy.ts`
**tagged to run on Serverless**\r\n-
`x-pack/test/security_solution_cypress/cypress/e2e/detection_response/rule_management/rule_actions/deletion/rule_delete.cy.ts`
**added disableAutorefresh() to avoid flakiness**\r\n\r\n## Related
failing-test issues\r\n\r\n###
`detection_response/detection_alerts`\r\n1.
https://github.com/elastic/kibana/issues/169091\r\n**Marked as
`legit-flake` and assigned to @elastic/security-detection-engine**
\r\n3. https://github.com/elastic/kibana/issues/163885\r\n\r\n###
`detection_response/value_lists`\r\n4.
https://github.com/elastic/kibana/issues/165699\r\n\r\n###
`detection_response/rule_creation`\r\n5.
https://github.com/elastic/kibana/issues/163691\r\n\r\n## Flaky test
runner\r\n\r\n-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3583\r\n-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3615
[SERVERLESS ONLY]\r\n-
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3656
[Serverless without indicator match and saved
queries]","sha":"939c87d95342c61f03c853cb3b34c9f412c303b0"}}]}]
BACKPORT-->

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team v8.11.0 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants