Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenAI Preconfigured Connector Dashboard Link #169148

Merged
merged 8 commits into from
Oct 24, 2023
Merged

OpenAI Preconfigured Connector Dashboard Link #169148

merged 8 commits into from
Oct 24, 2023

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Oct 17, 2023 •
edited by kibanamachine
Loading

Summary

When I implemented the dashboard to track OpenAI token usage, I did not consider preconfigured connectors. This PR adds a link from preconfigured edit connector flyout to token dashboard for OpenAI connectors.

Screenshot 2023-10-17 at 10 31 50 AM

To test

  1. Install an OpenAI to your kibana.dev.yml. You can use these credentials
  2. Go to Stack Management > Connectors
  3. Select the preconfigured connector
  4. Use the "Test" tab to send a message so there will be data in your dashboard (or don't - dashboard will work either way)
  5. On the "Configuration" tab, click the link that says View Usage Dashboard...
  6. Observe the dashboard.

@stephmilovic stephmilovic added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.12.0 v8.11.1 labels Oct 17, 2023
@stephmilovic stephmilovic requested a review from a team as a code owner October 17, 2023 16:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@stephmilovic stephmilovic requested a review from a team as a code owner October 18, 2023 18:10
semd
semd approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
stackConnectors 261 262 +1
triggersActionsUi 595 596 +1
total +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
triggersActionsUi 553 554 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackConnectors 515.6KB 524.4KB +8.9KB
triggersActionsUi 1.4MB 1.4MB +334.0B
total +9.2KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
triggersActionsUi 54 55 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
stackConnectors 38.3KB 38.4KB +82.0B
Unknown metric groups

API count

id before after diff
triggersActionsUi 579 580 +1

async chunk count

id before after diff
stackConnectors 75 76 +1

ESLint disabled line counts

id before after diff
stackConnectors 103 104 +1

Total ESLint disabled count

id before after diff
stackConnectors 108 109 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

doakalexi
doakalexi approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@doakalexi doakalexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stephmilovic stephmilovic merged commit 75e9d46 into elastic:main Oct 24, 2023
@stephmilovic stephmilovic deleted the preconfig_dashboard_link branch October 24, 2023 17:49
@kibanamachine kibanamachine mentioned this pull request Oct 24, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 24, 2023
@stephmilovic
OpenAI Preconfigured Connector Dashboard Link (elastic#169148)
dfa732e 
(cherry picked from commit 75e9d46)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 24, 2023
@kibanamachine @stephmilovic
[8.11] OpenAI Preconfigured Connector Dashboard Link (#169148) (#169700)
23db1e1 
# Backport

This will backport the following commits from `main` to `8.11`:
- [OpenAI Preconfigured Connector Dashboard Link
(#169148)](#169148)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Steph
Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-24T17:49:29Z","message":"OpenAI
Preconfigured Connector Dashboard Link
(#169148)","sha":"75e9d46b4b3a6ff5be4ffc324ba282cea0faea0c","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat
Hunting","Team:
SecuritySolution","v8.11.0","v8.12.0"],"number":169148,"url":"https://github.com/elastic/kibana/pull/169148","mergeCommit":{"message":"OpenAI
Preconfigured Connector Dashboard Link
(#169148)","sha":"75e9d46b4b3a6ff5be4ffc324ba282cea0faea0c"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169148","number":169148,"mergeCommit":{"message":"OpenAI
Preconfigured Connector Dashboard Link
(#169148)","sha":"75e9d46b4b3a6ff5be4ffc324ba282cea0faea0c"}}]}]
BACKPORT-->

Co-authored-by: Steph Milovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doakalexi doakalexi doakalexi approved these changes

@semd semd semd approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v8.11.0 v8.12.0
Projects
No open projects
AppEx: ResponseOps - Execution & Connectors
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@stephmilovic @elasticmachine @kibana-ci @kibanamachine @semd @doakalexi