[8.11] [SLO] Fix SLO burn rate rule to call alertWithLifecycle before getAlertUuid (#169004)
#169026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AlertUuid` (elastic#169004) ## Summary This PR fixes elastic#168962 by calling `alertWithLifecycle` before `getAlertUuid`. When `getAlertUuid` is called first it will generate a UUID which is not associated with the actual alert. When you call `alertWithLifecycle`, it generates the Alert then stores the `alertUuid` that maps the `alertId` to the `alertUuid`; `getAlertUuid` tries to recall this association but falls back to generating a UUID. I had to change the way the test worked by modifying mock's behavior to match the implementation; once I had a test that failed similarly to what we see in the real world, I fixed the issue by changing the implementation to call `alertWithLifecycle` first Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 48bb5ae)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.11:alertWithLifecyclebeforegetAlertUuid(#169004)Questions ?
Please refer to the Backport tool documentation