Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unsupported settings from index template #168968

Merged
merged 5 commits into from
Oct 17, 2023
Merged

Remove unsupported settings from index template #168968

merged 5 commits into from
Oct 17, 2023

Conversation

nkhristinin
Copy link
Contributor

@nkhristinin nkhristinin commented Oct 16, 2023 •
edited
Loading

Summary

those settings not working in serverless

@nkhristinin nkhristinin requested a review from a team as a code owner October 16, 2023 14:05
@nkhristinin nkhristinin added the release_note:skip Skip the PR/issue when compiling release notes label Oct 16, 2023
rylnd
rylnd approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These settings don't seem critical for ESS so I think we can just wholesale remove them (as you have done). I believe we have some tests that make assertions on our initialization calls to ES, so those will need to be updated here, but LGTM.

@rylnd
Copy link
Contributor

rylnd commented Oct 16, 2023

@nkhristinin make sure to add the appropriate labels and backport this to 8.11.

@nkhristinin nkhristinin requested a review from a team as a code owner October 16, 2023 15:48
@nkhristinin nkhristinin requested a review from rylnd October 16, 2023 18:11
@nkhristinin
Copy link
Contributor Author

@elasticmachine merge upstream

rylnd
rylnd approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@oatkiller oatkiller merged commit 79e9f50 into elastic:main Oct 17, 2023
@kibanamachine kibanamachine added v8.12.0 backport:skip This commit does not require backporting labels Oct 17, 2023
dej611 pushed a commit to dej611/kibana that referenced this pull request Oct 17, 2023
@nkhristinin @kibanamachine @dej611
Remove unsupported settings from index template (elastic#168968)
3a40191 
## Summary
those settings[ not working
](elastic#168406 (comment))
in serverless

---------

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylnd rylnd rylnd approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nkhristinin @rylnd @kibana-ci @oatkiller @kibanamachine