Fix autocomplete triggering on URL tokens

[sakurai-youhei]

Summary

This PR fixes autocomplete triggering on URL tokens for url parameters to work with a single character.

Fixes #168017 (which is a regression introduced by #163233)

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

Notes

• No functional tests are added because they would also go flaky.
• No unit tests are added because of the lack of existing unit tests.
• The change is kept minimal by accepting the growing if-else block.

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[yuliacech]

Hi @sakurai-youhei, I tested locally and still seeing the issue: autocomplete suggestions are not immediately displayed. I clarified more and added a screen recording in this comment.

[sakurai-youhei]

@elasticmachine merge upstream

[sakurai-youhei]

Hi @yuliacech I have revised this PR accordingly. The key points are:

• The complex conditions are concealed into !looksLikeTypingIn(lastEvaluatedToken, currentToken, editor) now.
• This change is still reverted to keep [Console] Unnecessary autocomplete suggestions for HTTP methods #156254 fixed.

Here are diffs between v8.10.4/v7.17.14 and this branch for your reference.

v8.10.4..fix-autocomplete-on-url-parameters

$ git diff v8.10.4..fix-autocomplete-on-url-parameters -- src/plugins/console/public/lib/autocomplete/autocomplete.ts

diff --git a/src/plugins/console/public/lib/autocomplete/autocomplete.ts b/src/plugins/console/public/lib/autocomplete/autocomplete.ts
index 71cca789264..ec543a1663d 100644
--- a/src/plugins/console/public/lib/autocomplete/autocomplete.ts
+++ b/src/plugins/console/public/lib/autocomplete/autocomplete.ts
@@ -1077,22 +1128,18 @@ export default function ({
         nextToken.position.lineNumber = pos.lineNumber;
         lastEvaluatedToken = nextToken;
       }
+      tracer('not starting autocomplete due to empty current token');
       return;
     }

     if (!lastEvaluatedToken) {
       lastEvaluatedToken = currentToken;
+      tracer('not starting autocomplete due to invalid last evaluated token');
       return; // wait for the next typing.
     }

-    // if the column or the line number have not changed for the last token and
-    // user did not provided a new value, then we should not show autocomplete
-    // this guards against triggering autocomplete when clicking around the editor
-    if (
-      (lastEvaluatedToken.position.column !== currentToken.position.column ||
-        lastEvaluatedToken.position.lineNumber !== currentToken.position.lineNumber) &&
-      lastEvaluatedToken.value === currentToken.value
-    ) {
+    if (!looksLikeTypingIn(lastEvaluatedToken, currentToken, editor)) {
+      tracer('not starting autocomplete', lastEvaluatedToken, '->', currentToken);
       // not on the same place or nothing changed, cache and wait for the next time
       lastEvaluatedToken = currentToken;
       return;

v7.17.14..fix-autocomplete-on-url-parameters

$ git diff v7.17.14..fix-autocomplete-on-url-parameters -- src/plugins/console/public/lib/autocomplete/autocomplete.ts

diff --git a/src/plugins/console/public/lib/autocomplete/autocomplete.ts b/src/plugins/console/public/lib/autocomplete/autocomplete.ts
index d89a9f3d2e5..ec543a1663d 100644
--- a/src/plugins/console/public/lib/autocomplete/autocomplete.ts
+++ b/src/plugins/console/public/lib/autocomplete/autocomplete.ts
@@ -921,19 +1128,18 @@ export default function ({
         nextToken.position.lineNumber = pos.lineNumber;
         lastEvaluatedToken = nextToken;
       }
+      tracer('not starting autocomplete due to empty current token');
       return;
     }

     if (!lastEvaluatedToken) {
       lastEvaluatedToken = currentToken;
+      tracer('not starting autocomplete due to invalid last evaluated token');
       return; // wait for the next typing.
     }

-    if (
-      lastEvaluatedToken.position.column !== currentToken.position.column ||
-      lastEvaluatedToken.position.lineNumber !== currentToken.position.lineNumber ||
-      lastEvaluatedToken.value === currentToken.value
-    ) {
+    if (!looksLikeTypingIn(lastEvaluatedToken, currentToken, editor)) {
+      tracer('not starting autocomplete', lastEvaluatedToken, '->', currentToken);
       // not on the same place or nothing changed, cache and wait for the next time
       lastEvaluatedToken = currentToken;
       return;

[sakurai-youhei]

Find I didn't make this PR ready for review.

EDIT: And I apologize for the post-ready code changes.

[kibana-ci]

💔 Build Failed

• Buildkite Build
• Commit: 2363efa
• Interpreting CI Failures

Failed CI Steps

• Defend Workflows Cypress Tests, burning changed specs #1
• Defend Workflows Cypress Tests on Serverless #2
• Security Solution Cypress tests, burning changed specs #1

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
console	199	200	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
console	403.6KB	404.6KB	+1.0KB

History

• 💔 Build #169284 failed cdcbd3b
• 💔 Build #169172 failed bb0aa60
• 💚 Build #168140 succeeded 2a672c9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[elasticmachine]

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

[yuliacech]

Thanks a lot for fixing this issue, @sakurai-youhei!
I tested locally and the regression is not reproducible, I also haven't noticed any other issues. Code changes LGTM too, thanks for adding the tests.

[kibanamachine]

💚 All backports created successfully

Status	Branch	Result
✅	8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

[kibanamachine]

💚 All backports created successfully

Status	Branch	Result
✅	8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

[sakurai-youhei]

Thank you for your review, @yuliacech !