Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SecuritySolution] Global search bar Edit Additional Filter not working #168955

Merged
merged 10 commits into from
Oct 31, 2023
Merged

[SecuritySolution] Global search bar Edit Additional Filter not working #168955

merged 10 commits into from
Oct 31, 2023

Conversation

angorayc
Copy link
Contributor

@angorayc angorayc commented Oct 16, 2023 •
edited by kibanamachine
Loading

Summary

The issue and steps to reproduce: #164406

Root cause: https://github.com/elastic/kibana/pull/168955/files#r1360612921

After:

Screen.Recording.2023-10-16.at.13.25.41.mov

Checklist

Delete any items that are not applicable to this PR.

@angorayc angorayc changed the title Issue 164406 [SecuritySolution] Pass SourcererDataView to SiemSearchBar Oct 16, 2023
angorayc
angorayc commented Oct 16, 2023
View reviewed changes
x-pack/plugins/security_solution/public/common/components/search_bar/index.tsx
<div data-test-subj={`${id}DatePicker`}>
<SearchBar
appName="siem"
isLoading={isLoading}
indexPatterns={indexPatterns as DataView[]}
indexPatterns={dataViews}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the type casting here by implementing Line 299-305, so we can get the exact DataView type. This allows Search Bar to receive the correct data view and fix #164406

@angorayc angorayc self-assigned this Oct 16, 2023
@angorayc angorayc added bug Fixes for quality problems that affect the customer experience v8.11.0 v8.12.0 v8.11.1 release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore and removed v8.11.0 labels Oct 16, 2023
@angorayc angorayc marked this pull request as ready for review October 25, 2023 13:13
@angorayc angorayc requested review from a team as code owners October 25, 2023 13:13
@angorayc angorayc requested a review from dplumlee October 25, 2023 13:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@angorayc angorayc changed the title [SecuritySolution] Pass SourcererDataView to SiemSearchBar [SecuritySolution] Global search bar Edit Additional Filter not working Oct 26, 2023
dplumlee
dplumlee approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@dplumlee dplumlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rules management changes lgtm

rylnd
rylnd approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@rylnd rylnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one question about the updated use of memo on the search bar component (I suspect the semantics have changed slightly?), but the EA changes LGTM.

x-pack/plugins/security_solution/public/common/components/search_bar/index.tsx Show resolved Hide resolved
maxcold
maxcold approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@maxcold maxcold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubernetes_security changes lgtm

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.8MB 12.8MB +350.0B
threatIntelligence 56.5KB 56.6KB +125.0B
total +475.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @angorayc

stephmilovic
stephmilovic approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@stephmilovic stephmilovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix

@lgestc
Copy link
Contributor

lgestc commented Oct 30, 2023

thank you, looks okay :)

@angorayc angorayc merged commit c054a2d into elastic:main Oct 31, 2023
@kibanamachine kibanamachine mentioned this pull request Oct 31, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 31, 2023
@angorayc
[SecuritySolution] Global search bar Edit Additional Filter not worki…
2dbb5fc 
…ng (elastic#168955)

## Summary

The issue and steps to reproduce:
elastic#164406

Root cause:
https://github.com/elastic/kibana/pull/168955/files#r1360612921

After:

https://github.com/elastic/kibana/assets/6295984/dc338c53-2f04-4f8b-a794-ff188606332a

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit c054a2d)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.11

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 1, 2023
@kibanamachine @angorayc
[8.11] [SecuritySolution] Global search bar Edit Additional Filter no…
24b4712 
…t working (#168955) (#170215)

# Backport

This will backport the following commits from `main` to `8.11`:
- [[SecuritySolution] Global search bar Edit Additional Filter not
working (#168955)](#168955)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Angela
Chuang","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-31T10:28:44Z","message":"[SecuritySolution]
Global search bar Edit Additional Filter not working (#168955)\n\n##
Summary\r\n\r\nThe issue and steps to
reproduce:\r\nhttps://github.com//issues/164406\r\n\r\nRoot
cause:\r\nhttps://github.com//pull/168955/files#r1360612921\r\n\r\nAfter:\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/6295984/dc338c53-2f04-4f8b-a794-ff188606332a\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"c054a2d32ac9e6f3cca5ef5cdd61ca2a42b5e95a","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Threat
Hunting","Team: SecuritySolution","Team:Threat
Hunting:Explore","v8.12.0","v8.11.1"],"number":168955,"url":"https://github.com/elastic/kibana/pull/168955","mergeCommit":{"message":"[SecuritySolution]
Global search bar Edit Additional Filter not working (#168955)\n\n##
Summary\r\n\r\nThe issue and steps to
reproduce:\r\nhttps://github.com//issues/164406\r\n\r\nRoot
cause:\r\nhttps://github.com//pull/168955/files#r1360612921\r\n\r\nAfter:\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/6295984/dc338c53-2f04-4f8b-a794-ff188606332a\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"c054a2d32ac9e6f3cca5ef5cdd61ca2a42b5e95a"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168955","number":168955,"mergeCommit":{"message":"[SecuritySolution]
Global search bar Edit Additional Filter not working (#168955)\n\n##
Summary\r\n\r\nThe issue and steps to
reproduce:\r\nhttps://github.com//issues/164406\r\n\r\nRoot
cause:\r\nhttps://github.com//pull/168955/files#r1360612921\r\n\r\nAfter:\r\n\r\n\r\n\r\nhttps://github.com/elastic/kibana/assets/6295984/dc338c53-2f04-4f8b-a794-ff188606332a\r\n\r\n\r\n\r\n###
Checklist\r\n\r\nDelete any items that are not applicable to this
PR.\r\n\r\n\r\n- [x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"c054a2d32ac9e6f3cca5ef5cdd61ca2a42b5e95a"}},{"branch":"8.11","label":"v8.11.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Angela Chuang <[email protected]>
@banderror banderror mentioned this pull request Dec 28, 2023
Closed
@PhilippeOberti PhilippeOberti mentioned this pull request Mar 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dplumlee dplumlee dplumlee approved these changes

@lgestc lgestc lgestc approved these changes

@stephmilovic stephmilovic stephmilovic approved these changes

@rylnd rylnd rylnd approved these changes

@maxcold maxcold maxcold approved these changes

Assignees

@angorayc angorayc

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team v8.11.0 v8.11.1 v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@angorayc @elasticmachine @kibana-ci @lgestc @kibanamachine @maxcold @rylnd @stephmilovic @dplumlee