[data views] Allow data views created on hidden and system indices - second attempt

src/plugins/data_view_editor/public/components/data_view_editor_flyout_content.tsx

@@ -105,6 +105,7 @@ const IndexPatternEditorFlyoutContentComponent = ({
             title: editData.getIndexPattern(),
             id: editData.id,
             name: editData.name,
+            allowHidden: editData.getAllowHidden(),
             ...(editData.timeFieldName
               ? {
                   timestampField: { label: editData.timeFieldName, value: editData.timeFieldName },

src/plugins/data_view_editor/public/components/data_view_flyout_content_container.tsx

@@ -50,10 +50,11 @@ const DataViewFlyoutContentContainer = ({
     try {
       let saveResponse;
       if (editData) {
-        const { name = '', timeFieldName, title = '' } = dataViewSpec;
+        const { name = '', timeFieldName, title = '', allowHidden } = dataViewSpec;
         editData.setIndexPattern(title);
         editData.name = name;
         editData.timeFieldName = timeFieldName;
+        editData.setAllowHidden(allowHidden || false);
         saveResponse = editData.isPersisted()
           ? await dataViews.updateSavedObject(editData)
           : editData;

src/plugins/data_views/common/content_management/v1/cm_services.ts

@@ -46,6 +46,7 @@ const dataViewAttributesSchema = schema.object(
     allowNoIndex: schema.maybe(schema.boolean()),
     runtimeFieldMap: schema.maybe(schema.any()),
     name: schema.maybe(schema.string()),
+    allowHidden: schema.maybe(schema.boolean()),
   },
   { unknowns: 'forbid' }
 );

src/plugins/data_views/common/data_views/data_view.ts

@@ -206,6 +206,8 @@ export class DataView implements DataViewBase {
 
   getAllowHidden = () => this.allowHidden;
 
+  setAllowHidden = (allowHidden: boolean) => (this.allowHidden = allowHidden);
+
   /**
    * Set index pattern
    * @param string index pattern string
@@ -466,6 +468,7 @@ export class DataView implements DataViewBase {
       allowNoIndex: this.allowNoIndex ? this.allowNoIndex : undefined,
       runtimeFieldMap: runtimeFieldMap ? JSON.stringify(runtimeFieldMap) : undefined,
       name: this.name,
+      allowHidden: this.allowHidden,
     };
   }
 

src/plugins/data_views/common/data_views/data_views.ts

@@ -810,6 +810,7 @@ export class DataViewsService {
         type,
         rollupIndex: typeMeta?.params?.rollup_index,
         allowNoIndex: spec.allowNoIndex,
+        allowHidden: spec.allowHidden,
       },
       spec.fieldAttrs,
       displayErrors

src/plugins/data_views/public/data_views/data_views_api_client.ts

@@ -60,6 +60,7 @@ export class DataViewsApiClient implements IDataViewsApiClient {
       indexFilter,
       includeUnmapped,
       fields,
+      allowHidden,
     } = options;
     return this._request<FieldsForWildcardResponse>(
       FIELDS_FOR_WILDCARD_PATH,
@@ -71,6 +72,7 @@ export class DataViewsApiClient implements IDataViewsApiClient {
         allow_no_index: allowNoIndex,
         include_unmapped: includeUnmapped,
         fields,
+        allow_hidden: allowHidden,
       },
       indexFilter ? JSON.stringify({ index_filter: indexFilter }) : undefined
     ).then((response) => {

src/plugins/data_views/server/content_management/data_views_storage.ts

@@ -37,6 +37,7 @@ export class DataViewsStorage extends SOContentStorage<DataViewCrudTypes> {
         'runtimeFieldMap',
         'allowNoIndex',
         'name',
+        'allowHidden',
       ],
       mSearchAdditionalSearchFields: ['name'],
       logger,

src/plugins/data_views/server/fetcher/lib/es_api.ts

@@ -46,7 +46,7 @@ interface FieldCapsApiParams {
   fieldCapsOptions?: { allow_no_indices: boolean; include_unmapped?: boolean };
   indexFilter?: QueryDslQueryContainer;
   fields?: string[];
-  expandWildcard?: ExpandWildcard;
+  expandWildcards?: ExpandWildcard;
 }
 
 /**
@@ -71,6 +71,7 @@ export async function callFieldCapsApi(params: FieldCapsApiParams) {
       include_unmapped: false,
     },
     fields = ['*'],
+    expandWildcards,
   } = params;
   try {
     return await callCluster.fieldCaps(
@@ -79,6 +80,7 @@ export async function callFieldCapsApi(params: FieldCapsApiParams) {
         fields,
         ignore_unavailable: true,
         index_filter: indexFilter,
+        expand_wildcards: expandWildcards,
         ...fieldCapsOptions,
       },
       { meta: true }

src/plugins/data_views/server/fetcher/lib/field_capabilities/field_capabilities.test.js

@@ -34,7 +34,7 @@ describe('index_patterns/field_capabilities/field_capabilities', () => {
   const fillUndefinedParams = (args) => ({
     callCluster: undefined,
     indices: undefined,
-    expandWildcard: undefined,
+    expandWildcards: undefined,
     fieldCapsOptions: undefined,
     indexFilter: undefined,
     fields: undefined,

src/plugins/data_views/server/fetcher/lib/field_capabilities/field_capabilities.ts

@@ -52,7 +52,7 @@ export async function getFieldCapabilities(params: FieldCapabilitiesParams) {
     fieldCapsOptions,
     indexFilter,
     fields,
-    expandWildcard: expandWildcards,
+    expandWildcards,
   });
   const fieldCapsArr = readFieldCapsResponse(esFieldCaps.body);
   const fieldsFromFieldCapsByName = keyBy(fieldCapsArr, 'name');

test/functional/apps/management/data_views/_data_view_create_delete.ts

@@ -254,10 +254,10 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
 
     describe('hidden index support', () => {
       it('can create data view against hidden index', async () => {
-        const pattern = 'logstash-2015.09.21';
+        const pattern = 'logstash-2015.09.2*';
 
         await es.transport.request({
-          path: '/logstash-2015.09.21/_settings',
+          path: '/logstash-2015.09.2*/_settings',
           method: 'PUT',
           body: {
             index: {
@@ -276,6 +276,15 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         );
         const patternName = await PageObjects.settings.getIndexPageHeading();
         expect(patternName).to.be(pattern);
+
+        // verify that allow hidden persists through reload
+        await browser.refresh();
+
+        await testSubjects.click('editIndexPatternButton');
+        await testSubjects.click('toggleAdvancedSetting');
+        const allowHiddenField = await testSubjects.find('allowHiddenField');
+        const button = await allowHiddenField.findByTagName('button');
+        expect(await button.getAttribute('aria-checked')).to.be('true');
       });
     });
   });

test/functional/page_objects/settings_page.ts

@@ -472,7 +472,8 @@ export class SettingsPageObject extends FtrService {
 
   async allowHiddenClick() {
     await this.testSubjects.click('toggleAdvancedSetting');
-    await this.testSubjects.click('allowHiddenField');
+    const allowHiddenField = await this.testSubjects.find('allowHiddenField');
+    (await allowHiddenField.findByTagName('button')).click();
   }
 
   async createIndexPattern(

x-pack/plugins/logs_shared/server/services/log_views/log_views_client.test.ts

@@ -298,6 +298,7 @@ describe('LogViewsClient class', () => {
               "type": "keyword",
             },
           },
+          "setAllowHidden": [Function],
           "setFieldFormat": [Function],
           "setIndexPattern": [Function],
           "shortDotsEnable": false,