Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KibanaErrorBoundary initial implementation #168754

Merged
merged 59 commits into from
Oct 23, 2023
Merged

KibanaErrorBoundary initial implementation #168754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
d79d5c5
KibanaErrorBoundary with Fatal error implementation
tsullivan Oct 12, 2023
3f6d7bd
Reporting management app error boundary
tsullivan Oct 13, 2023
8ae90f5
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Oct 13, 2023
83bb621
implement "soft" error message
tsullivan Oct 13, 2023
5d407bd
side effects should not appear directly inside the body of a component
tsullivan Oct 13, 2023
4700a45
reset reporting
tsullivan Oct 15, 2023
bda5264
Reference implementation for SharedUX management apps
tsullivan Oct 15, 2023
957ee1b
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Oct 15, 2023
45d8560
sync with code changes from poc branch
tsullivan Oct 16, 2023
d4a4bda
Merge branch 'main' into sharedux/error-boundary-ii
tsullivan Oct 16, 2023
1f8e327
pr cleanup
tsullivan Oct 16, 2023
e8ebb2d
re-fix useMemo
tsullivan Oct 16, 2023
ba420c5
Merge branch 'main' into sharedux/error-boundary-ii
tsullivan Oct 16, 2023
dc15a23
polish
tsullivan Oct 16, 2023
cf81e93
change user-facing text per feedback.
tsullivan Oct 16, 2023
8784b20
Add jest unit testing
tsullivan Oct 16, 2023
c2559e8
Ensure the ErrorBoundary package is part of the shared-deps bundle
tsullivan Oct 17, 2023
e9cf725
Rename to KibanaErrorBoundary
tsullivan Oct 17, 2023
047b271
fix package build reference
tsullivan Oct 17, 2023
d0757f3
Merge branch 'main' into sharedux/error-boundary-ii
tsullivan Oct 17, 2023
4bc61e9
--wip-- [skip ci]
tsullivan Oct 17, 2023
3e37880
Revert "fix package build reference"
tsullivan Oct 17, 2023
a907a02
Revert "Ensure the ErrorBoundary package is part of the shared-deps b…
tsullivan Oct 17, 2023
68cf0bf
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Oct 17, 2023
539415f
Merge branch 'main' into sharedux/error-boundary-ii
tsullivan Oct 17, 2023
58eb8a9
Revert "--wip-- [skip ci]"
tsullivan Oct 17, 2023
21573a1
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Oct 17, 2023
e281111
Replace EuiErrorBoundary in KibanaRenderContextProvider
tsullivan Oct 17, 2023
0e48b4a
Merge branch 'sharedux/error-boundary-ii' of github.com:tsullivan/kib…
tsullivan Oct 17, 2023
a25f52d
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Oct 17, 2023
015769d
Revert changes to individual management pages
tsullivan Oct 17, 2023
0f306f7
update snapshot core overlays browser-internal services
tsullivan Oct 18, 2023
f0a58ce
Merge branch 'main' into sharedux/error-boundary-ii
tsullivan Oct 18, 2023
bb49260
Update design per feedback
tsullivan Oct 18, 2023
f76ff90
Merge branch 'main' into sharedux/error-boundary-ii
tsullivan Oct 18, 2023
5925e34
Ensure the ErrorBoundary package is part of the shared-deps bundle [II]
tsullivan Oct 18, 2023
d2aaad4
chore(NA): include @kbn/shared-ux-error-boundary in ui shared deps src
mistic Oct 18, 2023
e0e3099
[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…
kibanamachine Oct 18, 2023
ed73007
implement copy error to clipboard
tsullivan Oct 18, 2023
b864106
Merge branch 'sharedux/error-boundary-ii' of github.com:tsullivan/kib…
tsullivan Oct 18, 2023
c34a14a
increase dataViewManagement bundle limit
tsullivan Oct 18, 2023
7309f83
Merge branch 'main' into sharedux/error-boundary-ii
tsullivan Oct 18, 2023
5a17940
Merge branch 'main' into sharedux/error-boundary-ii
tsullivan Oct 18, 2023
2ab706a
Improve storybooks
tsullivan Oct 18, 2023
57c8506
Update content per review
tsullivan Oct 18, 2023
1c420da
add an api doc
tsullivan Oct 18, 2023
f6f6c66
Merge branch 'main' into sharedux/error-boundary-ii
tsullivan Oct 18, 2023
3f88017
fix jest test
tsullivan Oct 19, 2023
251a1ce
Merge branch 'main' into sharedux/error-boundary-ii
tsullivan Oct 19, 2023
a5ce5ff
Merge branch 'main' into sharedux/error-boundary-ii
tsullivan Oct 19, 2023
0287190
Context value is a single object that never changes
tsullivan Oct 19, 2023
cb43013
Services as a distinct prop to the internal component
tsullivan Oct 20, 2023
438742b
use explicit type for React component
tsullivan Oct 20, 2023
94fc6ee
use React event naming
tsullivan Oct 20, 2023
248576e
Merge branch 'main' into sharedux/error-boundary-ii
tsullivan Oct 20, 2023
238a361
fix ts error
tsullivan Oct 20, 2023
70895c5
unit test for KibanaErrorService
tsullivan Oct 20, 2023
23c77fa
Merge branch 'main' into sharedux/error-boundary-ii
tsullivan Oct 20, 2023
fbdadcd
Merge branch 'main' into sharedux/error-boundary-ii
kibanamachine Oct 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -681,6 +681,7 @@ packages/shared-ux/card/no_data/impl @elastic/appex-sharedux
packages/shared-ux/card/no_data/mocks @elastic/appex-sharedux
packages/shared-ux/card/no_data/types @elastic/appex-sharedux
packages/shared-ux/chrome/navigation @elastic/appex-sharedux
packages/shared-ux/error_boundary @elastic/appex-sharedux
packages/shared-ux/file/context @elastic/appex-sharedux
packages/shared-ux/file/image/impl @elastic/appex-sharedux
packages/shared-ux/file/image/mocks @elastic/appex-sharedux
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,6 +684,7 @@
"@kbn/shared-ux-card-no-data-mocks": "link:packages/shared-ux/card/no_data/mocks",
"@kbn/shared-ux-card-no-data-types": "link:packages/shared-ux/card/no_data/types",
"@kbn/shared-ux-chrome-navigation": "link:packages/shared-ux/chrome/navigation",
"@kbn/shared-ux-error-boundary": "link:packages/shared-ux/error_boundary",
"@kbn/shared-ux-file-context": "link:packages/shared-ux/file/context",
"@kbn/shared-ux-file-image": "link:packages/shared-ux/file/image/impl",
"@kbn/shared-ux-file-image-mocks": "link:packages/shared-ux/file/image/mocks",
Expand Down
84 changes: 46 additions & 38 deletions ...lays/core-overlays-browser-internal/src/flyout/__snapshots__/flyout_service.test.tsx.snap
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading