[Security Solution] Fixes ES|QL Tab resetting to KQL Bar #168716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logeekal
changed the title
logeekal
added
Team:Threat Hunting:Investigations
lgestc
approved these changes
Oct 13, 2023
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 13, 2023
) ## Summary Handles elastic#168431 This PR fixes a race condition which was causing Discover ES|QL tab to revert to it KQL query bar. See demo below: | Before | After | |---|---| | <video src="https://github.com/elastic/kibana/assets/7485038/24ff8ca9-30ce-4581-94d7-52908a2c81fd" />|<video src="https://github.com/elastic/kibana/assets/7485038/746946ad-bd69-412f-bd38-d3d79b570c68" />| (cherry picked from commit 6fd6966)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 13, 2023
) (#168784) # Backport This will backport the following commits from `main` to `8.11`: - [[Security Solution] Fixes ES|QL Tab resetting to KQL Bar (#168716)](#168716) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-13T06:22:06Z","message":"[Security Solution] Fixes ES|QL Tab resetting to KQL Bar (#168716)\n\n## Summary\r\n\r\nHandles #168431\r\n\r\nThis PR fixes a race condition which was causing Discover ES|QL tab to\r\nrevert to it KQL query bar. See demo below:\r\n\r\n| Before | After |\r\n|---|---|\r\n| <video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/24ff8ca9-30ce-4581-94d7-52908a2c81fd\"\r\n/>|<video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/746946ad-bd69-412f-bd38-d3d79b570c68\"\r\n/>|","sha":"6fd6966ed8225935feee247b04b4988424b47c88","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Threat Hunting:Investigations","v8.11.0","v8.12.0"],"number":168716,"url":"https://github.com/elastic/kibana/pull/168716","mergeCommit":{"message":"[Security Solution] Fixes ES|QL Tab resetting to KQL Bar (#168716)\n\n## Summary\r\n\r\nHandles #168431\r\n\r\nThis PR fixes a race condition which was causing Discover ES|QL tab to\r\nrevert to it KQL query bar. See demo below:\r\n\r\n| Before | After |\r\n|---|---|\r\n| <video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/24ff8ca9-30ce-4581-94d7-52908a2c81fd\"\r\n/>|<video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/746946ad-bd69-412f-bd38-d3d79b570c68\"\r\n/>|","sha":"6fd6966ed8225935feee247b04b4988424b47c88"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168716","number":168716,"mergeCommit":{"message":"[Security Solution] Fixes ES|QL Tab resetting to KQL Bar (#168716)\n\n## Summary\r\n\r\nHandles #168431\r\n\r\nThis PR fixes a race condition which was causing Discover ES|QL tab to\r\nrevert to it KQL query bar. See demo below:\r\n\r\n| Before | After |\r\n|---|---|\r\n| <video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/24ff8ca9-30ce-4581-94d7-52908a2c81fd\"\r\n/>|<video\r\nsrc=\"https://github.com/elastic/kibana/assets/7485038/746946ad-bd69-412f-bd38-d3d79b570c68\"\r\n/>|","sha":"6fd6966ed8225935feee247b04b4988424b47c88"}}]}] BACKPORT--> Co-authored-by: Jatin Kathuria <[email protected]>
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
) ## Summary Handles elastic#168431 This PR fixes a race condition which was causing Discover ES|QL tab to revert to it KQL query bar. See demo below: | Before | After | |---|---| | <video src="https://github.com/elastic/kibana/assets/7485038/24ff8ca9-30ce-4581-94d7-52908a2c81fd" />|<video src="https://github.com/elastic/kibana/assets/7485038/746946ad-bd69-412f-bd38-d3d79b570c68" />|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Handles #168431
This PR fixes a race condition which was causing Discover ES|QL tab to revert to it KQL query bar. See demo below:
ES.QL.-.KQL.Bar.issue.mov
ES.QL.-.KQL.Bar.issue.Resolved.mov