kibana_usage_collection: optimize SO PIT searches
#168677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
Team:Core
pgayvallet
force-pushed
the
kbn-xxx-usage_collection_pit_optims
branch
from
47e34b8 to
13c6ac7
Compare
|
Pinging @elastic/kibana-core (Team:Core) |
afharo
approved these changes
Oct 13, 2023
Comment on lines
+92
to
+93
| savedObjectsClient.bulkDelete( | ||
| usageDailyIdsToDelete.map((id) => ({ id, type: SAVED_OBJECTS_DAILY_TYPE })) |
| return accum; | ||
| }, {} as Record<string, number>); | ||
|
|
||
| const counts: Record<string, number> = {}; |
There was a problem hiding this comment.
NIT: We may be able to convert this to an ES aggregation, so there's no need to loop through all documents.
WDYT?
There was a problem hiding this comment.
There was a problem hiding this comment.
Yeah, I came to the same conclusion after I adapted the code. I wanted to try it, but in a follow-up (this one was initially supposed to be only for the usage collection calls)
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
## Summary Properly loop though PIT search pages instead of fetching all documents at once --------- Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Properly loop though PIT search pages instead of fetching all documents at once