Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OAS] Add serverless connector APIs #168661

Merged
merged 8 commits into from
Oct 17, 2023
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 12, 2023

Summary

Relates to #152378

This PR creates a separate openAPI specification for the connector APIs that are available in Elastic Serverless.
From my tests, at this time these APIs don't differ from their classic counterparts except they:

  • Support only API key authentication
  • Do not support space ID path parameters

Since I do not yet know what privileges or roles are required to run these APIs, I have omitted that information for now.

I've also made the following fixes and changes:

  • Clarified that the config is not visible when in the response when it's a preconfigured connector.
  • Added reference_by_count to the response schema with a note in its description that it's applicable only to the "get all connectors" APIs.
  • Added the missing generativeAI feature value.

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs Feature:Actions/ConnectorsManagement Issues related to Connectors Management UX labels Oct 12, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl marked this pull request as ready for review October 13, 2023 02:16
@lcawl lcawl requested a review from a team as a code owner October 13, 2023 02:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@lcawl lcawl force-pushed the serverless-connectors branch from f262e02 to a735f2e Compare October 17, 2023 01:57
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Security Solution Cypress Tests #1 / Enrichment Custom query rule from new risk scores Should has enrichment fields from legacy risk Should has enrichment fields from legacy risk

Metrics [docs]

✅ unchanged

History

  • 💛 Build #167849 was flaky f262e027eb2d0b2d77cbc87110746f4d351cd167
  • 💔 Build #167567 failed 7e2d59044afa8f9e45d69363dcbbf91998f2e16a
  • 💔 Build #167558 failed 82d454c1b276e82bc8af56a6064df2e31355fcd9
  • 💔 Build #167532 failed 6c279c5b827e2a461bc964a23df27f42897d3eb7
  • 💛 Build #167482 was flaky c8b63fb4b55511126ceaf62794bb2e7678a44773
  • 💛 Build #167174 was flaky ad080816c21445f4d61d3805f97433e8d64caee9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl lcawl merged commit fb387ba into elastic:main Oct 17, 2023
@lcawl lcawl deleted the serverless-connectors branch October 17, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting docs Feature:Actions/ConnectorsManagement Issues related to Connectors Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

6 participants