Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data views, getExistingIndices method to server side #168522

Merged
merged 12 commits into from
Oct 16, 2023

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Oct 10, 2023

Summary

Moves the repeated calls to getFieldsForWildcard from the getExistingIndices method to the server side

Screenshot 2023-10-11 at 11 41 06 AM

@stephmilovic stephmilovic added release_note:skip Skip the PR/issue when compiling release notes v8.12.0 labels Oct 10, 2023
@mattkime
Copy link
Contributor

@stephmilovic Clearly I've broken nearly everything. I could use your help figuring out what broke where. Its hard for me to imagine its anything complicated.

@stephmilovic stephmilovic marked this pull request as ready for review October 11, 2023 17:39
@stephmilovic stephmilovic requested review from a team as code owners October 11, 2023 17:39
Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, nice work!

Copy link
Contributor

@dhurley14 dhurley14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving on this so quickly!

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Investigations - Security Solution Cypress Tests #1 / timeline data providers persists timeline when a field is added by hover action "Add To Timeline" in data provider persists timeline when a field is added by hover action "Add To Timeline" in data provider

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
dataViews 262 263 +1

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
dataViews 2 3 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataViews 46.2KB 45.7KB -487.0B
Unknown metric groups

API count

id before after diff
data 3290 3288 -2
dataViews 1048 1045 -3
total -5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic stephmilovic merged commit 91435a5 into elastic:main Oct 16, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 16, 2023
@stephmilovic stephmilovic deleted the existing_indices_route branch October 16, 2023 20:19
dej611 pushed a commit to dej611/kibana that referenced this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants