[ML] AIOps: Fixes Data View runtime fields support in Change point detection UI #168249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
release_note:fix
:ml
Team:ML
|
Pinging @elastic/ml-ui (:ml) |
qn895
reviewed
Oct 6, 2023
x-pack/plugins/aiops/public/components/change_point_detection/use_change_point_agg_request.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Tested and fixed in the change point detection page in AIOps Labs.
Is the runtime mapping config passed along in the embeddable? When I tried adding the change point detection charts to a dashboard, I see the 'No change points found' message inside Dashboard.
|
@elasticmachine merge upstream |
@peteharverson fixed by f889cc7 |
|
Code LGTM 🎉 |
qn895
approved these changes
Oct 9, 2023
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @darnautov |
peteharverson
approved these changes
Oct 10, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 10, 2023
…ction UI (elastic#168249) ## Summary Fixes [elastic#162212](elastic#168212) If a Data View runtime field is used as a metric or split field, appends a `runtime_mappings` to the search request. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 9f06e30)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 10, 2023
…nt detection UI (#168249) (#168491) # Backport This will backport the following commits from `main` to `8.11`: - [[ML] AIOps: Fix Data View runtime fields support in Change point detection UI (#168249)](#168249) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-10T14:55:03Z","message":"[ML] AIOps: Fix Data View runtime fields support in Change point detection UI (#168249)\n\n## Summary\r\n\r\nFixes [#162212](https://github.com/elastic/kibana/issues/168212)\r\n\r\nIf a Data View runtime field is used as a metric or split field, appends\r\na `runtime_mappings` to the search request.\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"9f06e30a4e9addf1db6a3e78a11103d644e37995","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Team:ML","Feature:ML/AIOps","v8.11.0","v8.12.0"],"number":168249,"url":"https://github.com/elastic/kibana/pull/168249","mergeCommit":{"message":"[ML] AIOps: Fix Data View runtime fields support in Change point detection UI (#168249)\n\n## Summary\r\n\r\nFixes [#162212](https://github.com/elastic/kibana/issues/168212)\r\n\r\nIf a Data View runtime field is used as a metric or split field, appends\r\na `runtime_mappings` to the search request.\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"9f06e30a4e9addf1db6a3e78a11103d644e37995"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/168249","number":168249,"mergeCommit":{"message":"[ML] AIOps: Fix Data View runtime fields support in Change point detection UI (#168249)\n\n## Summary\r\n\r\nFixes [#162212](https://github.com/elastic/kibana/issues/168212)\r\n\r\nIf a Data View runtime field is used as a metric or split field, appends\r\na `runtime_mappings` to the search request.\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"9f06e30a4e9addf1db6a3e78a11103d644e37995"}}]}] BACKPORT--> Co-authored-by: Dima Arnautov <[email protected]>
szabosteve
changed the title
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
…ction UI (elastic#168249) ## Summary Fixes [elastic#162212](elastic#168212) If a Data View runtime field is used as a metric or split field, appends a `runtime_mappings` to the search request. ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #162212
If a Data View runtime field is used as a metric or split field, appends a
runtime_mappingsto the search request.Checklist