Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAM] Create serverless functional tests for rule details #168101

Conversation

guskovaue
Copy link
Contributor

@guskovaue guskovaue commented Oct 5, 2023

Part of #167301.

Serverless functional tests for rule details on Search.

I did not copy all rule details tests to serverless. Some of them will be copied after soon rules changes: #168965

guskovaue and others added 25 commits September 8, 2023 16:31
…of github.com:guskovaue/kibana into RAM-create-serverless-functional-tests-for-rules-list
…of github.com:guskovaue/kibana into RAM-create-serverless-functional-tests-for-rules-list
…into RAM-create-serverless-functional-tests-for-rule-details
…' of github.com:guskovaue/kibana into RAM-create-serverless-functional-tests-for-rule-details
@guskovaue guskovaue self-assigned this Oct 9, 2023
@guskovaue guskovaue changed the title [RAM} Create serverless functional tests for rule details [RAM] Create serverless functional tests for rule details Oct 9, 2023
@guskovaue guskovaue added v8.12.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Oct 9, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @guskovaue

@guskovaue guskovaue marked this pull request as ready for review October 17, 2023 08:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Copy link
Contributor

@Zacqary Zacqary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, can you add the new /rules/ test suite to CODEOWNERS? Under this heading: https://github.com/elastic/kibana/blob/main/.github/CODEOWNERS#L1117

Copy link
Contributor

@Zacqary Zacqary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to expedite merge, please add CODEOWNERS defs though

@guskovaue guskovaue merged commit c2e4d40 into elastic:main Oct 23, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 23, 2023
@guskovaue
Copy link
Contributor Author

@Zacqary Here https://github.com/elastic/kibana/blob/main/.github/CODEOWNERS#L1117 it's said htat the file is autogenerated during CI. What should I do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

5 participants