-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: Kibana React Error Boundary #168054
POC: Kibana React Error Boundary #168054
Conversation
bacfeb9
to
8a3a85c
Compare
c4eacc2
to
8a00c07
Compare
8a00c07
to
9aab5c4
Compare
The first PR will not implement the "inline" error treatment, but only the "callout" treatment. I'm keeping this as a closed PR so we can come back and reference the full POC implementation. Replacing this PR with #168754 |
This reverts commit bf11b802b2258482349deb65740f4d96ff1a81b5.
💔 Build FailedFailed CI Steps
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Closed: replaced with #169010
Summary
Address #167159
Technical doc [Elastic internal] https://docs.google.com/document/d/1kVD3T08AzLuvRMnFrXzWd6rTQWZDFfjqmOMCoXRI-14/edit
This PR creates the
KibanaErrorBoundary
component andKibanaErrorService
utility, and shows it in use in two main areas that control lazy-loaded UI elements:Stack Management. This PR handles the error that could occur when navigating across management apps, and async code needed to render the app failed to load.
Share Menu Manager. This PR handles the error that could occur when the Share Menu Manager calls on a ShareMenuItem to render itself, and async code that is needed fails to load.
Testing
Checklist
Delete any items that are not applicable to this PR.