Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove KUI Framework #167833

Merged
merged 8 commits into from
Oct 4, 2023
Merged

Remove KUI Framework #167833

merged 8 commits into from
Oct 4, 2023

Conversation

Ikuni17
Copy link
Contributor

@Ikuni17 Ikuni17 commented Oct 2, 2023

Summary

Closes #46410

Removes the deprecated @kbn/ui-framework

@Ikuni17 Ikuni17 added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.11.0 labels Oct 2, 2023
@Ikuni17 Ikuni17 self-assigned this Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Documentation preview:

@Ikuni17 Ikuni17 marked this pull request as ready for review October 2, 2023 23:17
@Ikuni17 Ikuni17 requested review from a team as code owners October 2, 2023 23:17
@Ikuni17 Ikuni17 enabled auto-merge (squash) October 2, 2023 23:23
jloleysens
jloleysens approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes LGTM, did not test locally!

jbudz
jbudz approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe for follow up, cc @elastic/kibana-visualizations :

We can probably remove package.json/font-awesome. I still see icons in a few places:

  1. src/plugins/vis_types/timeseries/public/application/components/vis_editor_visualization.js
  2. src/plugins/vis_types/timeseries/public/application/components/icon_select/icon_select.js

but I don't see it actually imported anywhere since the merge of #162048.

@stratoula
Copy link
Contributor

@jbudz thanx for pinging us. I created an technical dept issue here #167949. These are icons we can easily get rid of.

@Ikuni17 Ikuni17 merged commit 2ff938e into elastic:main Oct 4, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Ikuni17

@Ikuni17 Ikuni17 deleted the chore/46410/remove-kui branch February 9, 2024 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jloleysens jloleysens jloleysens approved these changes

@MichaelMarcialis MichaelMarcialis MichaelMarcialis approved these changes

@jbudz jbudz jbudz approved these changes

Assignees

@Ikuni17 Ikuni17

Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove usages of @kbn/ui-framework
7 participants
@Ikuni17 @stratoula @kibana-ci @jbudz @MichaelMarcialis @jloleysens @kibanamachine