Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AO] Add testing action variables to the Custom threshold rule API integration tests #167757

Merged
merged 7 commits into from
Oct 4, 2023
Merged

[AO] Add testing action variables to the Custom threshold rule API integration tests #167757

merged 7 commits into from
Oct 4, 2023

Conversation

maryam-saeidi
Copy link
Member

Closes #162950
Closes #161237

Summary

This PR adds testing action variables to the Custom threshold rule API integration tests.

@maryam-saeidi maryam-saeidi added chore release_note:skip Skip the PR/issue when compiling release notes labels Oct 2, 2023
@maryam-saeidi maryam-saeidi self-assigned this Oct 2, 2023
@apmmachine
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@maryam-saeidi maryam-saeidi marked this pull request as ready for review October 2, 2023 10:50
@maryam-saeidi maryam-saeidi requested a review from a team as a code owner October 2, 2023 10:50
fkanout
fkanout reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@fkanout fkanout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maryam-saeidi I remember you mentioned the goal is to test all the available action variables. Does it covers them all? do we have a list?

@maryam-saeidi
Copy link
Member Author

maryam-saeidi commented Oct 2, 2023 •
edited
Loading

@maryam-saeidi I remember you mentioned the goal is to test all the available action variables. Does it covers them all? do we have a list?

There are many action variables; the ones you see in this PR's interface are the important ones that we added and need to be tested.

@maryam-saeidi maryam-saeidi requested a review from fkanout October 3, 2023 11:38
@maryam-saeidi
Copy link
Member Author

Failure is related to #167869

fkanout
fkanout reviewed Oct 3, 2023
View reviewed changes
Copy link
Contributor

@fkanout fkanout left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As #167644 is merged, can you please update the tests on serverless, too?

x-pack/test/alerting_api_integration/observability/custom_threshold_rule/group_by_fired.ts
host: string;
group: string;
}>({
const resp = await waitForDocumentInIndex<ActionDocument>({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we remove the rule type, host, etc.?

Copy link
Member Author

@maryam-saeidi maryam-saeidi Oct 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't remove it, I replaced it with ActionDocument type.

@maryam-saeidi maryam-saeidi mentioned this pull request Oct 3, 2023
Closed
@maryam-saeidi
Copy link
Member Author

maryam-saeidi commented Oct 3, 2023 •
edited
Loading

As #167644 is merged, can you please update the tests on serverless, too?

@fkanout created a separate ticket so we don't expand this ticket's scope. Also, we disabled this rule for serverless, so it is more important to have this test for stateful.

@maryam-saeidi maryam-saeidi enabled auto-merge (squash) October 3, 2023 15:26
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #10 / APM API tests alerts/transaction_error_rate.spec.ts basic no archive transaction error rate alert create rule without kql query "after all" hook for "shows the correct alert count in opbeans-node service"

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maryam-saeidi

benakansara
benakansara approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@benakansara benakansara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maryam-saeidi maryam-saeidi merged commit 8a2843e into elastic:main Oct 4, 2023
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Oct 4, 2023
@maryam-saeidi maryam-saeidi deleted the 162950-test-action-variables branch October 4, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkanout fkanout fkanout left review comments

@benakansara benakansara benakansara approved these changes

Assignees

@maryam-saeidi maryam-saeidi

Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes v8.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AO] Add action variables testing for the new threshold rule [AO] Test scenarios for the new threshold rule
6 participants
@maryam-saeidi @apmmachine @kibana-ci @fkanout @benakansara @kibanamachine