[Security Solution] Test plan for prebuilt rule flyout #167727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikitaindik
force-pushed
the
rule-preview-test-scenarios
branch
from
4ec19fd to
2aaeca0
Compare
nikitaindik
added
release_note:skip
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
banderror
force-pushed
the
rule-preview-test-scenarios
branch
from
c40f3ed to
9aaae8a
Compare
banderror
reviewed
Oct 5, 2023
There was a problem hiding this comment.
Reviewed the plan and made some small adjustments to the scenarios w/o changing what they actually do and check.
One outstanding comment is that we should probably add some scenarios for hiding tabs and sections when there are no properties to show in them.
Other than that LGTM 👍
...lution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md
Outdated
Show resolved
Hide resolved
...lution/docs/testing/test_plans/detection_response/prebuilt_rules/installation_and_upgrade.md
Outdated
Show resolved
Hide resolved
banderror
approved these changes
Oct 17, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 17, 2023
**Resolves: elastic#166160 ## Summary Adds a test plan for the prebuilt rules flyout. Covers installation and upgrade actions and also the content shown in Overview and Investigation Guide tabs. <img width="1301" alt="Schermafbeelding 2023-10-03 om 22 29 39" src="https://github.com/elastic/kibana/assets/15949146/1aa7aa8b-3746-4767-82ad-f4910034d5eb"> --------- Co-authored-by: Georgii Gorbachev <[email protected]> (cherry picked from commit 930b440)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 17, 2023
… (#169155) # Backport This will backport the following commits from `main` to `8.11`: - [[Security Solution] Test plan for prebuilt rule flyout (#167727)](#167727) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nikita Indik","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-17T17:44:13Z","message":"[Security Solution] Test plan for prebuilt rule flyout (#167727)\n\n**Resolves: https://github.com/elastic/kibana/issues/166160**\r\n\r\n## Summary\r\n\r\nAdds a test plan for the prebuilt rules flyout. Covers installation and\r\nupgrade actions and also the content shown in Overview and Investigation\r\nGuide tabs.\r\n\r\n<img width=\"1301\" alt=\"Schermafbeelding 2023-10-03 om 22 29 39\"\r\nsrc=\"https://github.com/elastic/kibana/assets/15949146/1aa7aa8b-3746-4767-82ad-f4910034d5eb\">\r\n\r\n---------\r\n\r\nCo-authored-by: Georgii Gorbachev <[email protected]>","sha":"930b440c9b91a99a3b3398d5d4941d67c88d9128","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","test-plan","Team:Detections and Resp","Team: SecuritySolution","Team:Detection Rule Management","Feature:Prebuilt Detection Rules","v8.11.0","v8.12.0"],"number":167727,"url":"https://github.com/elastic/kibana/pull/167727","mergeCommit":{"message":"[Security Solution] Test plan for prebuilt rule flyout (#167727)\n\n**Resolves: https://github.com/elastic/kibana/issues/166160**\r\n\r\n## Summary\r\n\r\nAdds a test plan for the prebuilt rules flyout. Covers installation and\r\nupgrade actions and also the content shown in Overview and Investigation\r\nGuide tabs.\r\n\r\n<img width=\"1301\" alt=\"Schermafbeelding 2023-10-03 om 22 29 39\"\r\nsrc=\"https://github.com/elastic/kibana/assets/15949146/1aa7aa8b-3746-4767-82ad-f4910034d5eb\">\r\n\r\n---------\r\n\r\nCo-authored-by: Georgii Gorbachev <[email protected]>","sha":"930b440c9b91a99a3b3398d5d4941d67c88d9128"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/167727","number":167727,"mergeCommit":{"message":"[Security Solution] Test plan for prebuilt rule flyout (#167727)\n\n**Resolves: https://github.com/elastic/kibana/issues/166160**\r\n\r\n## Summary\r\n\r\nAdds a test plan for the prebuilt rules flyout. Covers installation and\r\nupgrade actions and also the content shown in Overview and Investigation\r\nGuide tabs.\r\n\r\n<img width=\"1301\" alt=\"Schermafbeelding 2023-10-03 om 22 29 39\"\r\nsrc=\"https://github.com/elastic/kibana/assets/15949146/1aa7aa8b-3746-4767-82ad-f4910034d5eb\">\r\n\r\n---------\r\n\r\nCo-authored-by: Georgii Gorbachev <[email protected]>","sha":"930b440c9b91a99a3b3398d5d4941d67c88d9128"}}]}] BACKPORT--> Co-authored-by: Nikita Indik <[email protected]>
hop-dev
pushed a commit
to hop-dev/kibana
that referenced
this pull request
Oct 18, 2023
**Resolves: elastic#166160 ## Summary Adds a test plan for the prebuilt rules flyout. Covers installation and upgrade actions and also the content shown in Overview and Investigation Guide tabs. <img width="1301" alt="Schermafbeelding 2023-10-03 om 22 29 39" src="https://github.com/elastic/kibana/assets/15949146/1aa7aa8b-3746-4767-82ad-f4910034d5eb"> --------- Co-authored-by: Georgii Gorbachev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #166160
Summary
Adds a test plan for the prebuilt rules flyout. Covers installation and upgrade actions and also the content shown in Overview and Investigation Guide tabs.