Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Unskipping x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout/ working tests on serverless #167512

Conversation

MadameSheema
Copy link
Member

@MadameSheema MadameSheema commented Sep 28, 2023

Summary

In this PR we are making the following changes regarding the tests living in x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout/ regarding their execution on the first quality gate for serverless:

Note that the unskipped tests have been executed several times and are passing consistently :)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Investigations - Security Solution Cypress Tests #3 / Discover Timeline State Integration saved search "before each" hook for "should rename the saved search on timeline rename" "before each" hook for "should rename the saved search on timeline rename"

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@MadameSheema MadameSheema changed the title adding expandable flyout tests to serverless [Security Solution] Unskipping x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout/ working tests on serverless Oct 3, 2023
@MadameSheema MadameSheema self-assigned this Oct 3, 2023
@MadameSheema MadameSheema added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Investigations Security Solution Investigations Team v8.11.0 labels Oct 3, 2023
@MadameSheema MadameSheema marked this pull request as ready for review October 3, 2023 11:01
@MadameSheema MadameSheema requested a review from a team as a code owner October 3, 2023 11:01
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@MadameSheema MadameSheema enabled auto-merge (squash) October 3, 2023 12:50
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MadameSheema thank you for going through all of these, for the details PR description and for the tickets created.
Code LGTM I'm glad we have a lot more tests running in Serverless for the flyout!

@MadameSheema MadameSheema merged commit 8d78de9 into elastic:main Oct 3, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 3, 2023
@MadameSheema MadameSheema deleted the maximizing-serverless-coverage/expandaable-flyout branch June 28, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants