[UnifiedDocViewer] Remove usage of KibanaContextProvider #167202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasolson
added
Team:DataDiscovery
…lson/kibana into unified-doc-viewer/remove-context
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
lukasolson
added
release_note:skip
davismcphee
approved these changes
Nov 17, 2023
src/plugins/unified_doc_viewer/public/hooks/use_doc_viewer_services.ts
Outdated
Show resolved
Hide resolved
botelastic
bot
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
|
@elasticmachine merge upstream |
shahzad31
reviewed
Nov 20, 2023
Comment on lines
-29
to
+24
| const { data: hit } = useFetcher<Promise<DataTableRecord | undefined>>(async () => { | ||
| if (!dataView?.id || !isFlyoutVisible) return; | ||
| const response = await data.search | ||
| .search({ | ||
| params: { | ||
| index: SYNTHETICS_INDEX_PATTERN, | ||
| body: { | ||
| query: { | ||
| ids: { | ||
| values: [ping.docId], | ||
| }, | ||
| }, | ||
| fields: ['*'], | ||
| _source: false, | ||
| }, | ||
| }, | ||
| }) | ||
| .toPromise(); | ||
| const docs = response?.rawResponse?.hits?.hits ?? []; | ||
| if (docs.length > 0) { | ||
| return buildDataTableRecord(docs[0], dataView); | ||
| } | ||
| }, [data, dataView, ping.docId, isFlyoutVisible]); | ||
| const [, hit] = useEsDocSearch({ id: ping.docId, index: SYNTHETICS_INDEX_PATTERN, dataView }); |
shahzad31
approved these changes
Nov 20, 2023
…lson/kibana into unified-doc-viewer/remove-context
…lson/kibana into unified-doc-viewer/remove-context
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @lukasolson |
jennypavlova
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes usages of
KibanaContextProviderto simplify the API of theUnifiedDocViewercomponent. Instead, necessary services are accessed from the plugin itself (viagetUnifiedDocViewerServices). Removes theuseUnifiedDocViewerServiceshook since it's no longer needed.Resolves #168380
Checklist