[RAM] Enable read-only users to access rules #167003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbopepato
added
release_note:fix
Team:ResponseOps
…rs-cannot-see-rules
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
LGTM! |
guskovaue
approved these changes
Oct 4, 2023
maryam-saeidi
approved these changes
Oct 5, 2023
| ); | ||
| await retry.waitFor( | ||
| 'Create rule button is disabled', | ||
| async () => !(await testSubjects.isEnabled('createRuleButton')) |
There was a problem hiding this comment.
Question: How exactly does the assertion work here?
There was a problem hiding this comment.
I inverted the return value of the isEnabled utility to check that the button is disabled. Don't know if there are better utilities for such a case, but it seemed pretty straightforward 🙂
Absolutely! We were thinking of addressing this in another PR 🙂 |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 6, 2023
Closes elastic#166613 ## Summary Enables users with read privilege on `Stack rules` to see the rules table and the rule detail page without editing capabilities. Before:  After:  In case of empty rules lists, the prompt "Create your first rule" was shown, even to users without create permissions:  To avoid confusion, read-only users now see the empty table instead:  In the rule detail page, users without access to `Actions and Connectors` now see a missing privileges message under `Actions` in the details panel instead of `No actions` and a `Forbidden` error toast.  Finally, the original missing authorization prompt now shows "read" instead of "create":  ## To test - Create an Elasticsearch query rule - Create a Role with read privilege granted in `Stack rules` (under Kibana > Management) and assign it to a user - Create a test user with the created role - Log in as the test user - Navigate to Stack Management > Rules - Check that the rules table is visible, with create and update actions disabled ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) --------- Co-authored-by: Xavier Mouligneau <[email protected]> (cherry picked from commit e49628a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 6, 2023
# Backport This will backport the following commits from `main` to `8.11`: - [[RAM] Enable read-only users to access rules (#167003)](#167003) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Umberto Pepato","email":"[email protected]"},"sourceCommit":{"committedDate":"2023-10-06T16:01:18Z","message":"[RAM] Enable read-only users to access rules (#167003)\n\nCloses #166613\r\n\r\n## Summary\r\n\r\nEnables users with read privilege on `Stack rules` to see the rules\r\ntable and the rule detail page without editing capabilities. Before:\r\n\r\n\r\n\r\n\r\nAfter:\r\n\r\n\r\n\r\n\r\nIn case of empty rules lists, the prompt \"Create your first rule\" was\r\nshown, even to users without create permissions:\r\n\r\n\r\n\r\n\r\nTo avoid confusion, read-only users now see the empty table instead:\r\n\r\n\r\n\r\n\r\nIn the rule detail page, users without access to `Actions and\r\nConnectors` now see a missing privileges message under `Actions` in the\r\ndetails panel instead of `No actions` and a `Forbidden` error toast.\r\n\r\n\r\n\r\n\r\nFinally, the original missing authorization prompt now shows \"read\"\r\ninstead of \"create\":\r\n\r\n\r\n\r\n\r\n## To test\r\n\r\n- Create an Elasticsearch query rule\r\n- Create a Role with read privilege granted in `Stack rules` (under\r\nKibana > Management) and assign it to a user\r\n- Create a test user with the created role\r\n- Log in as the test user\r\n- Navigate to Stack Management > Rules\r\n- Check that the rules table is visible, with create and update actions\r\ndisabled\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by: Xavier Mouligneau <[email protected]>","sha":"e49628acabcb8c566f9d30a72b88129151f829ee","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:ResponseOps","v8.11.0","v8.12.0"],"number":167003,"url":"https://github.com/elastic/kibana/pull/167003","mergeCommit":{"message":"[RAM] Enable read-only users to access rules (#167003)\n\nCloses #166613\r\n\r\n## Summary\r\n\r\nEnables users with read privilege on `Stack rules` to see the rules\r\ntable and the rule detail page without editing capabilities. Before:\r\n\r\n\r\n\r\n\r\nAfter:\r\n\r\n\r\n\r\n\r\nIn case of empty rules lists, the prompt \"Create your first rule\" was\r\nshown, even to users without create permissions:\r\n\r\n\r\n\r\n\r\nTo avoid confusion, read-only users now see the empty table instead:\r\n\r\n\r\n\r\n\r\nIn the rule detail page, users without access to `Actions and\r\nConnectors` now see a missing privileges message under `Actions` in the\r\ndetails panel instead of `No actions` and a `Forbidden` error toast.\r\n\r\n\r\n\r\n\r\nFinally, the original missing authorization prompt now shows \"read\"\r\ninstead of \"create\":\r\n\r\n\r\n\r\n\r\n## To test\r\n\r\n- Create an Elasticsearch query rule\r\n- Create a Role with read privilege granted in `Stack rules` (under\r\nKibana > Management) and assign it to a user\r\n- Create a test user with the created role\r\n- Log in as the test user\r\n- Navigate to Stack Management > Rules\r\n- Check that the rules table is visible, with create and update actions\r\ndisabled\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by: Xavier Mouligneau <[email protected]>","sha":"e49628acabcb8c566f9d30a72b88129151f829ee"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/167003","number":167003,"mergeCommit":{"message":"[RAM] Enable read-only users to access rules (#167003)\n\nCloses #166613\r\n\r\n## Summary\r\n\r\nEnables users with read privilege on `Stack rules` to see the rules\r\ntable and the rule detail page without editing capabilities. Before:\r\n\r\n\r\n\r\n\r\nAfter:\r\n\r\n\r\n\r\n\r\nIn case of empty rules lists, the prompt \"Create your first rule\" was\r\nshown, even to users without create permissions:\r\n\r\n\r\n\r\n\r\nTo avoid confusion, read-only users now see the empty table instead:\r\n\r\n\r\n\r\n\r\nIn the rule detail page, users without access to `Actions and\r\nConnectors` now see a missing privileges message under `Actions` in the\r\ndetails panel instead of `No actions` and a `Forbidden` error toast.\r\n\r\n\r\n\r\n\r\nFinally, the original missing authorization prompt now shows \"read\"\r\ninstead of \"create\":\r\n\r\n\r\n\r\n\r\n## To test\r\n\r\n- Create an Elasticsearch query rule\r\n- Create a Role with read privilege granted in `Stack rules` (under\r\nKibana > Management) and assign it to a user\r\n- Create a test user with the created role\r\n- Log in as the test user\r\n- Navigate to Stack Management > Rules\r\n- Check that the rules table is visible, with create and update actions\r\ndisabled\r\n\r\n### Checklist\r\n\r\n- [x] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n\r\n---------\r\n\r\nCo-authored-by: Xavier Mouligneau <[email protected]>","sha":"e49628acabcb8c566f9d30a72b88129151f829ee"}}]}] BACKPORT--> Co-authored-by: Umberto Pepato <[email protected]>
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
Closes elastic#166613 ## Summary Enables users with read privilege on `Stack rules` to see the rules table and the rule detail page without editing capabilities. Before:  After:  In case of empty rules lists, the prompt "Create your first rule" was shown, even to users without create permissions:  To avoid confusion, read-only users now see the empty table instead:  In the rule detail page, users without access to `Actions and Connectors` now see a missing privileges message under `Actions` in the details panel instead of `No actions` and a `Forbidden` error toast.  Finally, the original missing authorization prompt now shows "read" instead of "create":  ## To test - Create an Elasticsearch query rule - Create a Role with read privilege granted in `Stack rules` (under Kibana > Management) and assign it to a user - Create a test user with the created role - Log in as the test user - Navigate to Stack Management > Rules - Check that the rules table is visible, with create and update actions disabled ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) --------- Co-authored-by: Xavier Mouligneau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #166613
Summary
Enables users with read privilege on
Stack rulesto see the rules table and the rule detail page without editing capabilities. Before:After:
In case of empty rules lists, the prompt "Create your first rule" was shown, even to users without create permissions:
To avoid confusion, read-only users now see the empty table instead:
In the rule detail page, users without access to
Actions and Connectorsnow see a missing privileges message underActionsin the details panel instead ofNo actionsand aForbiddenerror toast.Finally, the original missing authorization prompt now shows "read" instead of "create":
To test
Stack rules(under Kibana > Management) and assign it to a userChecklist