Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] [Detections] reverts "Adds support for index patterns (DataViewBase) to be used for query bar filters #165262" #166176

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

vitaliidm
Copy link
Contributor

@vitaliidm vitaliidm commented Sep 11, 2023

Summary

Reverts #165262 due infinite loop of requests on rule creation page

__create.page.mov

As these requests carry large number of fields, it signiificantly affects Kibana performance as well

[2023-09-11T15:14:57.572+01:00][WARN ][http.server.Kibana] Event loop utilization for /kbn/api/ui_counters/_report exceeded threshold of 250ms (1109ms out of 1135ms) and 15% (98%)
[2023-09-11T15:15:10.780+01:00][WARN ][http.server.Kibana] Event loop utilization for /kbn/internal/data_views/_fields_for_wildcard exceeded threshold of 250ms (258ms out of 258ms) and 15% (100%)
[2023-09-11T15:15:10.787+01:00][WARN ][http.server.Kibana] Event loop utilization for /kbn/internal/data_views/_fields_for_wildcard exceeded threshold of 250ms (267ms out of 267ms) and 15% (100%)
[2023-09-11T15:15:10.789+01:00][WARN ][http.server.Kibana] Event loop utilization for /kbn/internal/data_views/_fields_for_wildcard exceeded threshold of 250ms (253ms out of 253ms) and 15% (100%)
[2023-09-11T15:15:11.735+01:00][WARN ][http.server.Kibana] Event loop utilization for /kbn/internal/data_views/_fields_for_wildcard exceeded threshold of 250ms (309ms out of 319ms) and 15% (97%)
[2023-09-11T15:15:12.484+01:00][WARN ][http.server.Kibana] Event loop utilization for /kbn/internal/data_views/_fields_for_wildcard exceeded threshold of 250ms (287ms out of 296ms) and 15% (97%)
[2023-09-11T15:15:12.578+01:00][WARN ][http.server.Kibana] Event loop utilization for /kbn/internal/data_views/_fields_for_wildcard exceeded threshold of 250ms (363ms out of 368ms) and 15% (98%)

This reverts commit 1accadb.

Summarize your PR. If it involves visual changes include a screenshot or gif.

…rns (DataViewBase) to be used for query bar filters (elastic#165262)"

This reverts commit 1accadb.
@vitaliidm vitaliidm marked this pull request as ready for review September 11, 2023 14:20
@vitaliidm vitaliidm requested a review from a team as a code owner September 11, 2023 14:20
@vitaliidm vitaliidm changed the title Revert "[Security Solution] [Detections] Adds support for index patte… [Security Solution] [Detections] reverts "Adds support for index patterns (DataViewBase) to be used for query bar filters #165262" Sep 11, 2023
@vitaliidm vitaliidm self-assigned this Sep 11, 2023
@vitaliidm vitaliidm added Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Engine Security Solution Detection Engine Area labels Sep 11, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@vitaliidm vitaliidm added the release_note:skip Skip the PR/issue when compiling release notes label Sep 11, 2023
@vitaliidm vitaliidm enabled auto-merge (squash) September 11, 2023 14:27
Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for catching this. I'll update the original issue as well.

Copy link
Contributor

@dhurley14 dhurley14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - I will work on a bug fix to remove the useEffect's dependency on the dataview.id

@vitaliidm vitaliidm enabled auto-merge (squash) September 11, 2023 14:54
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 11, 2023

💔 Build Failed

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.6MB 12.6MB -1.8KB
Unknown metric groups

References to deprecated APIs

id before after diff
securitySolution 657 652 -5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vitaliidm

@vitaliidm vitaliidm merged commit 6526280 into elastic:main Sep 11, 2023
@kibanamachine kibanamachine added v8.11.0 backport:skip This commit does not require backporting labels Sep 11, 2023
@vitaliidm vitaliidm deleted the reverse/data-view-fix branch March 4, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants