-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] [Detections] reverts "Adds support for index patterns (DataViewBase) to be used for query bar filters #165262" #166176
Conversation
…rns (DataViewBase) to be used for query bar filters (elastic#165262)" This reverts commit 1accadb.
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Pinging @elastic/security-solution (Team: SecuritySolution) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for catching this. I'll update the original issue as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm - I will work on a bug fix to remove the useEffect's dependency on the dataview.id
💔 Build FailedFailed CI StepsMetrics [docs]Async chunks
Unknown metric groupsReferences to deprecated APIs
HistoryTo update your PR or re-run it, just comment with: cc @vitaliidm |
Summary
Reverts #165262 due infinite loop of requests on rule creation page
__create.page.mov
As these requests carry large number of fields, it signiificantly affects Kibana performance as well
This reverts commit 1accadb.
Summarize your PR. If it involves visual changes include a screenshot or gif.