Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Defend Workflows] User receives warnings that an artifact is expiring and that they should update #166141

Merged
merged 12 commits into from
Oct 2, 2023

Conversation

szwarckonrad
Copy link
Contributor

@szwarckonrad szwarckonrad commented Sep 11, 2023

closes https://github.com/elastic/security-team/issues/7209

depends on elastic/security-docs#3902

Updated copy, Learn more link needs to be updated once docs are ready to be linked.

Screenshot 2023-09-11 at 11 16 33

@szwarckonrad szwarckonrad added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.11.0 labels Sep 11, 2023
@szwarckonrad szwarckonrad self-assigned this Sep 11, 2023
@szwarckonrad szwarckonrad requested a review from a team as a code owner September 11, 2023 09:22
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - but the wording on the message needs some adjusting

szwarckonrad and others added 5 commits September 11, 2023 17:26
…y/view/protection_updates/protection_updates_layout.tsx

Co-authored-by: Ash <[email protected]>
# Conflicts:
#	x-pack/plugins/security_solution/public/management/pages/policy/view/protection_updates/protection_updates_layout.tsx
@joepeeples
Copy link
Contributor

Tech writing follow-up:

  • UI copy looks fine to me, but admittedly this feature is brand-new to me. @paul-tavares you said earlier the wording needs adjusting, but I don't know enough about the feature yet to know what it needs. Maybe it'd help to explain more what "artifacts" are in this context, since we also use "artifacts" to refer to other policy features like trusted apps, event features, etc.? But that's more an issue with the whole feature, not just this warning message.

    I don't want to hold back this PR for feature freeze, so I think the current copy is good enough to merge, and we can iterate further if needed.

  • Docs stub page created in Defend artifact control: create stub page security-docs#4003, full URL is https://www.elastic.co/guide/en/security/master/artifact-control.html. This will be available in 30-45 min once the periodic docs refresh finishes rebuilding.

@paul-tavares
Copy link
Contributor

@joepeeples - looks like it got taken care of by Ash and Konrad

@szwarckonrad szwarckonrad requested a review from a team as a code owner October 2, 2023 08:43
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Defend Workflows Cypress Tests #4 / Artifact pages Trusted applications should update Endpoint Policy on Endpoint when adding Trusted application name should update Endpoint Policy on Endpoint when adding Trusted application name
  • [job] [logs] FTR Configs #63 / dashboard app - group 2 dashboard filter bar saved search filtering are added when a cell magnifying glass is clicked

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 147.0KB 147.1KB +44.0B
securitySolution 13.0MB 13.0MB +548.0B
total +592.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 368.0KB 368.1KB +44.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @szwarckonrad

@szwarckonrad szwarckonrad enabled auto-merge (squash) October 2, 2023 14:22
@benironside
Copy link
Contributor

@kevinlog , I just reviewed the updated copy. LGTM

Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants