Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky #158318] Catch start-thrown errors as they are irrelevant to this test #165319

Merged
merged 2 commits into from
Sep 1, 2023
Merged

[Flaky #158318] Catch start-thrown errors as they are irrelevant to this test #165319

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f525ae4
[Flaky #158318] Catch `start`-thrown errors as they are irrelevant to…
afharo Aug 31, 2023
1cae27a
Merge branch 'main' into flaky-158318
afharo Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ion_tests/saved_objects/migrations/group3/incompatible_cluster_routing_allocation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,9 @@ describe('incompatible_cluster_routing_allocation', () => {
await root.preboot();
await root.setup();

root.start();
root.start().catch(() => {
// Silent catch because the test might be done and call shutdown before starting is completed, causing unwanted thrown errors.
});

// Wait for the INIT -> INIT action retry
await retryAsync(
Expand Down